From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH mini-os enhancements for vtpm 1/8]
Date: Tue, 18 Sep 2012 00:23:28 +0200 [thread overview]
Message-ID: <20120917222328.GN5110@type.youpi.perso.aquilenet.fr> (raw)
In-Reply-To: <50579BA6.1080503@jhuapl.edu>
Matthew Fioravante, le Mon 17 Sep 2012 17:52:38 -0400, a écrit :
> b/extras/mini-os/arch/ia64/iorw.c
> +void iowrite8(volatile void* addr, uint8_t val)
> +{
> + printk("iorw not implemented!!\n");
Maybe even crash? Such things can be overlooked.
> +#include <mini-os/types.h>
> +
> +void iowrite8(volatile void* addr, uint8_t val);
> +void iowrite32(volatile void* addr, uint32_t val);
> +
> +uint8_t ioread8(volatile void* addr);
> +uint32_t ioread32(volatile void* addr);
I'd say while you are at it, add 16 and 64 variants.
Samuel
next prev parent reply other threads:[~2012-09-17 22:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 21:52 [PATCH mini-os enhancements for vtpm 1/8] Matthew Fioravante
2012-09-17 22:23 ` Samuel Thibault [this message]
2012-09-18 17:56 ` Matthew Fioravante
2012-09-18 18:07 ` Samuel Thibault
2012-09-18 7:23 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120917222328.GN5110@type.youpi.perso.aquilenet.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=matthew.fioravante@jhuapl.edu \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).