From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [PATCH v1 4/8]: PVH setup changes...
Date: Mon, 24 Sep 2012 15:48:34 -0700
Message-ID: <20120924154834.434dce06@mantra.us.oracle.com>
References: <20120921121752.5fa80b35@mantra.us.oracle.com>
	<alpine.DEB.2.02.1209241310380.29232@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1209241310380.29232@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>, Ian Campbell <Ian.Campbell@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 24 Sep 2012 13:14:45 +0100
Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:

> On Fri, 21 Sep 2012, Mukesh Rathor wrote:
> > @@ -500,10 +527,9 @@ void __cpuinit xen_enable_syscall(void)
> >  #endif /* CONFIG_X86_64 */
> >  }
> >  
> > -void __init xen_arch_setup(void)
> > +/* Non auto translated PV domain, ie, it's not PVH. */
> > +static __init void inline xen_non_pvh_arch_setup(void)
> >  {
> > -	xen_panic_handler_init();
> > -
> >  	HYPERVISOR_vm_assist(VMASST_CMD_enable,
> > VMASST_TYPE_4gb_segments); HYPERVISOR_vm_assist(VMASST_CMD_enable,
> > VMASST_TYPE_writable_pagetables); 
> > @@ -517,6 +543,15 @@ void __init xen_arch_setup(void)
> >  
> >  	xen_enable_sysenter();
> >  	xen_enable_syscall();
> > +}
> > +
> > +/* This function not called for HVM domain */
> > +void __init xen_arch_setup(void)
> > +{
> > +	xen_panic_handler_init();
> > +
> > +	if (!xen_feature(XENFEAT_auto_translated_physmap))
> > +		xen_non_pvh_arch_setup();
> >  
> >  #ifdef CONFIG_ACPI
> >  	if (!(xen_start_info->flags & SIF_INITDOMAIN)) {
>  
> IMHO having a xen_non_pvh_arch_setup function is less intuitive
> than just wrapping all that code around an
> 
> if (!xen_feature(XENFEAT_auto_translated_physmap)) {
> 
Too much indentation.

> Or at least you could name the function xen_pvmmu_arch_setup.

ok, fine, i'll rename it again.