From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. Date: Wed, 26 Sep 2012 08:49:16 -0400 Message-ID: <20120926124915.GH7356@phenom.dumpdata.com> References: <1348662212-3559-1-git-send-email-paul.durrant@citrix.com> <1348662212-3559-2-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1348662212-3559-2-git-send-email-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Paul Durrant , steve.prochniak@oracle.com, annie.li@oracle.com Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, Sep 26, 2012 at 01:23:31PM +0100, Paul Durrant wrote: > These product numbers are used by the QEMU blacklisting protocol in > traditional QEMU and are currently coded directly into the xenstore.c > source module. Since there are now multiple QEMUs this information > should be pulled into a public header to avoid duplication/conflict. > hvm-emulated-unplug.markdown has also been adjusted to reference the > new header. > > Signed-off-by: Paul Durrant > --- > docs/misc/hvm-emulated-unplug.markdown | 2 +- > xen/include/public/hvm/pvdrivers.h | 50 ++++++++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+), 1 deletions(-) > create mode 100644 xen/include/public/hvm/pvdrivers.h > > diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown > index 707fbab..ec9ce83 100644 > --- a/docs/misc/hvm-emulated-unplug.markdown > +++ b/docs/misc/hvm-emulated-unplug.markdown > @@ -65,4 +65,4 @@ decimal number. `{product_name}` is a string corresponding to the > product number in step 3. > > The master registry of product names and numbers is in > -qemu-xen-unstable's xenstore.c. > +xen/include/public/hvm/pvdrivers.h > diff --git a/xen/include/public/hvm/pvdrivers.h b/xen/include/public/hvm/pvdrivers.h > new file mode 100644 > index 0000000..4be57ac > --- /dev/null > +++ b/xen/include/public/hvm/pvdrivers.h > @@ -0,0 +1,50 @@ > +/* > + * pvdrivers.h: Register of PV drivers product numbers. > + * Copyright (c) 2012, Citrix Systems Inc. > + * > + * Permission is hereby granted, free of charge, to any person obtaining a copy > + * of this software and associated documentation files (the "Software"), to > + * deal in the Software without restriction, including without limitation the > + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > + * DEALINGS IN THE SOFTWARE. > + */ > + > +#ifndef _XEN_PUBLIC_PVDRIVERS_H_ > +#define _XEN_PUBLIC_PVDRIVERS_H_ > + > +/* > + * This is the master registry of product numbers for > + * PV drivers. > + * If you need a new product number allocating, please > + * post to xen-devel@lists.xensource.com. You should NOT use > + * a product number without allocating one. > + * If you maintain a separate versioning and distribution path > + * for PV drivers you should have a separate product number so > + * that your drivers can be separated from others. > + * > + * During development, you may use the product ID to > + * indicate a driver which is yet to be released. > + */ > + > +#define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ > +#define PVDRIVERS_XENSOURCE_WINDOWS_NAME "xensource-windows" > + > +#define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ > +#define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" And also the Oracle one :-) The Novell one looks to be using 107? > + > +#define PVDRIVERS_EXPERIMENTAL_ID 0xffff > +#define PVDRIVERS_EXPERIMENTAL_NAME "experimental" > + > +#endif /* _XEN_PUBLIC_PVDRIVERS_H_ */ > -- > 1.7.2.5 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel >