From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
"stefano.stabellini@eu.citrix.com"
<stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v1 2/8]: PVH mmu changes
Date: Wed, 26 Sep 2012 09:54:18 -0400 [thread overview]
Message-ID: <20120926135418.GA18392@phenom.dumpdata.com> (raw)
In-Reply-To: <20120921121556.1a0ea8af@mantra.us.oracle.com>
> @@ -24,9 +24,19 @@ int xen_create_contiguous_region(unsigned long vstart, unsigned int order,
> void xen_destroy_contiguous_region(unsigned long vstart, unsigned int order);
>
> struct vm_area_struct;
> +struct xen_pvh_pfn_info;
> int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
> unsigned long addr,
> unsigned long mfn, int nr,
> - pgprot_t prot, unsigned domid);
> + pgprot_t prot, unsigned domid,
> + struct xen_pvh_pfn_info *pvhp);
This change during a git bisection (where we only applied patch #1
and patch #2) will cause a build breakage like this:
/home/konrad/ssd/linux/drivers/xen/privcmd.c: In function ‘mmap_mfn_range’:
/home/konrad/ssd/linux/drivers/xen/privcmd.c:181: error: too few arguments to function ‘xen_remap_domain_mfn_range’
/home/konrad/ssd/linux/drivers/xen/privcmd.c: In function ‘mmap_batch_fn’:
/home/konrad/ssd/linux/drivers/xen/privcmd.c:270: error: too few arguments to function ‘xen_remap_domain_mfn_range’
make[4]: *** [drivers/xen/privcmd.o] Error 1
make[3]: *** [drivers/xen] Error 2
Please squash this patch:
diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index ef63895..802720c 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -178,7 +178,7 @@ static int mmap_mfn_range(void *data, void *state)
msg->va & PAGE_MASK,
msg->mfn, msg->npages,
vma->vm_page_prot,
- st->domain);
+ st->domain, NULL);
if (rc < 0)
return rc;
@@ -267,7 +267,7 @@ static int mmap_batch_fn(void *data, void *state)
int ret;
ret = xen_remap_domain_mfn_range(st->vma, st->va & PAGE_MASK, *mfnp, 1,
- st->vma->vm_page_prot, st->domain);
+ st->vma->vm_page_prot, st->domain, NULL);
/* Store error code for second pass. */
*(st->err++) = ret;
into this patch.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-09-26 13:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 19:15 [PATCH v1 2/8]: PVH mmu changes Mukesh Rathor
2012-09-24 11:55 ` Stefano Stabellini
2012-09-24 12:16 ` Ian Campbell
2012-09-24 12:24 ` Stefano Stabellini
2012-09-26 0:27 ` Mukesh Rathor
2012-09-26 11:10 ` George Dunlap
2012-09-26 11:16 ` Stefano Stabellini
2012-09-24 13:50 ` Konrad Rzeszutek Wilk
2012-09-26 0:09 ` Mukesh Rathor
2012-09-26 11:15 ` Stefano Stabellini
2012-10-01 21:32 ` Mukesh Rathor
2012-10-01 21:44 ` Mukesh Rathor
2012-10-02 11:23 ` Stefano Stabellini
2012-10-02 22:22 ` Mukesh Rathor
2012-10-02 10:46 ` Stefano Stabellini
2012-10-03 18:27 ` Mukesh Rathor
2012-10-04 8:18 ` Ian Campbell
2012-09-24 14:04 ` Stefano Stabellini
2012-09-24 14:13 ` Ian Campbell
2012-09-26 0:33 ` Mukesh Rathor
2012-09-26 11:25 ` Stefano Stabellini
2012-09-26 13:54 ` Konrad Rzeszutek Wilk [this message]
2012-10-02 10:49 ` Stefano Stabellini
2012-10-03 15:42 ` Ian Campbell
2012-10-03 22:29 ` Mukesh Rathor
2012-10-04 8:27 ` Ian Campbell
2012-10-04 18:27 ` Mukesh Rathor
2012-10-04 18:42 ` Konrad Rzeszutek Wilk
2012-10-05 9:25 ` Ian Campbell
2012-10-06 2:00 ` Mukesh Rathor
2012-10-08 9:31 ` Ian Campbell
2012-10-04 8:31 ` Ian Campbell
2012-10-05 1:17 ` Mukesh Rathor
2012-10-05 9:26 ` Ian Campbell
2012-10-04 13:54 ` Ian Campbell
2012-10-05 1:51 ` Mukesh Rathor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120926135418.GA18392@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Xen-devel@lists.xensource.com \
--cc=mukesh.rathor@oracle.com \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).