From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v1 1/8]: PVH basic and hader file changes Date: Tue, 2 Oct 2012 09:04:11 -0400 Message-ID: <20121002130411.GC9009@phenom.dumpdata.com> References: <20120921121511.30001c08@mantra.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: "Xen-devel@lists.xensource.com" , Ian Campbell List-Id: xen-devel@lists.xenproject.org The title says ' hader' - it should say 'header'. Also there is a missing description of what it does, and how this works. For an example check out: f4cec35b0d4b90d96e3770a3d1e68ea882e7a7c8 (which added the 1-1 P2M notion), or: 357a3cfb147ee8e97c6f9cdc51e9a33aa56f7d99 (for the > 128gb support). It needs to be verbose with lots of details. On Tue, Oct 02, 2012 at 11:48:13AM +0100, Stefano Stabellini wrote: > On Fri, 21 Sep 2012, Mukesh Rathor wrote: > > --- > > arch/x86/include/asm/xen/interface.h | 8 +++++++- > > arch/x86/include/asm/xen/page.h | 3 +++ > > arch/x86/xen/irq.c | 5 ++++- > > arch/x86/xen/p2m.c | 2 +- > > drivers/xen/cpu_hotplug.c | 4 +++- > > drivers/xen/events.c | 12 ++++++++---- > > drivers/xen/xenbus/xenbus_client.c | 2 +- > > drivers/xen/xenbus/xenbus_probe.c | 6 +++++- > > include/xen/interface/memory.h | 27 +++++++++++++++++++++++++++ > > include/xen/interface/physdev.h | 10 ++++++++++ > > 10 files changed, 69 insertions(+), 10 deletions(-)