Re: [PATCH v1 0/8]: PVH (PV guest with extensions)

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Wed, 3 Oct 2012 11:24:04 +0100
Ian Campbell <Ian.Campbell@citrix.com> wrote:

> On Tue, 2012-10-02 at 19:55 +0100, Mukesh Rathor wrote:
> > On Tue, 2 Oct 2012 09:09:11 -0400
> > Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> > 
 > > 
> > > > Strange, adding following to head.S
> > > > 
> > > >         ELFNOTE(Xen, XEN_ELFNOTE_PADDR_OFFSET,   _ASM_PTR 0)
> > > >         ELFNOTE(Xen, XEN_ELFNOTE_GUEST_PVH, .long 1)  <--------
> > > > 
> > > > and xenstore won't start in dom0. What gives?
> > > 
> > > What is XEN_ELFNOTE_GUEST_PVH number? You might be re-using a
> > > value that is defined for a different purpose? Did you check the
> > > Xen hypervisor header files?
> > 
> > Ah, right. I was looking at linux header file, which is behind xen.
> 
> Phew!
> 
> You are going to add the other features which PVH uses too, right?
> 
> Ian.
> 

Sorry, confused. Not very familiar with this. You mean, something like:

        ELFNOTE(Xen, XEN_ELFNOTE_GUEST_PVH,      .long 1)
        ELFNOTE(Xen, XEN_ELFNOTE_PVH_FEATURES,  .asciz "writable_page_tables|auto_translated_physmap|supervisor_mode_kernel|hvm_callback_vector")

Something like this?

thanks
Mukesh