Re: [PATCH v1 2/8]: PVH mmu changes

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Thu, 4 Oct 2012 09:31:36 +0100
Ian Campbell <Ian.Campbell@citrix.com> wrote:

> On Wed, 2012-10-03 at 23:29 +0100, Mukesh Rathor wrote:
> > On Wed, 3 Oct 2012 16:42:43 +0100
> > Ian Campbell <Ian.Campbell@citrix.com> wrote:
> > 
> > > 
> > > > diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> > > > index 6a198e4..6c5ad83 100644
> > > > --- a/include/xen/xen-ops.h
> > > > +++ b/include/xen/xen-ops.h
> > > > @@ -24,9 +24,19 @@ int xen_create_contiguous_region(unsigned
> > > > long vstart, unsigned int order, void
> > > > xen_destroy_contiguous_region(unsigned long vstart, unsigned int
> > > > order); struct vm_area_struct;
> > > > +struct xen_pvh_pfn_info;
> > > 
> > > If you move the struct def'n up you don't need this forward decl.
> > > 
> > > >  int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
> > > >  			       unsigned long addr,
> > > >  			       unsigned long mfn, int nr,
> > > > -			       pgprot_t prot, unsigned domid);
> > > > +			       pgprot_t prot, unsigned domid,
> > > > +			       struct xen_pvh_pfn_info *pvhp);
> > > > +int xen_unmap_domain_mfn_range(struct vm_area_struct *vma,
> > > > +			       struct xen_pvh_pfn_info *pvhp);
> > > > +
> > > > +struct xen_pvh_pfn_info {
> > > 
> > > Can we call this xen_remap_mfn_info or something? PVH is x86
> > > specific while this struct is also useful on ARM.
> > 
> > I already renamed it to: xen_xlat_pfn_info.
> 
> BTW, where can I find you latest patches?

In my local tree here. Will be submitting v3 soon.

> I've just noticed that you've not been CCing LKML with this series --
> was that deliberate?

I was told I didn't need to since there is no common code change.

thanks
Mukesh