* [PATCH] stubdom: fix error assignment in grub:load_module
@ 2012-10-09 13:04 Olaf Hering
2012-10-09 13:46 ` Samuel Thibault
0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2012-10-09 13:04 UTC (permalink / raw)
To: xen-devel
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1349787855 -7200
# Node ID 384714804b9b2a9742cc45dffaa43b749b85513b
# Parent 142e4577f5a9b95832b82f7b6d31fde1697cbe76
stubdom: fix error assignment in grub:load_module
[ 1333s] mini-os.c: In function 'load_module':
[ 1333s] mini-os.c:244: warning: statement with no effect
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r 142e4577f5a9 -r 384714804b9b stubdom/grub/mini-os.c
--- a/stubdom/grub/mini-os.c
+++ b/stubdom/grub/mini-os.c
@@ -241,7 +241,7 @@ load_module (char *module, char *arg)
if ((void*) (multiboot_next_module_header+1) - module_image > PAGE_SIZE) {
/* Too many modules */
- ERR_WONT_FIT;
+ errnum = ERR_WONT_FIT;
return 0;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] stubdom: fix error assignment in grub:load_module
2012-10-09 13:04 [PATCH] stubdom: fix error assignment in grub:load_module Olaf Hering
@ 2012-10-09 13:46 ` Samuel Thibault
2012-10-11 9:21 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Thibault @ 2012-10-09 13:46 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel
Olaf Hering, le Tue 09 Oct 2012 15:04:29 +0200, a écrit :
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1349787855 -7200
> # Node ID 384714804b9b2a9742cc45dffaa43b749b85513b
> # Parent 142e4577f5a9b95832b82f7b6d31fde1697cbe76
> stubdom: fix error assignment in grub:load_module
>
> [ 1333s] mini-os.c: In function 'load_module':
> [ 1333s] mini-os.c:244: warning: statement with no effect
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> diff -r 142e4577f5a9 -r 384714804b9b stubdom/grub/mini-os.c
> --- a/stubdom/grub/mini-os.c
> +++ b/stubdom/grub/mini-os.c
> @@ -241,7 +241,7 @@ load_module (char *module, char *arg)
>
> if ((void*) (multiboot_next_module_header+1) - module_image > PAGE_SIZE) {
> /* Too many modules */
> - ERR_WONT_FIT;
> + errnum = ERR_WONT_FIT;
> return 0;
> }
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
--
Samuel
/* Halley */
(Halley's comment.)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] stubdom: fix error assignment in grub:load_module
2012-10-09 13:46 ` Samuel Thibault
@ 2012-10-11 9:21 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2012-10-11 9:21 UTC (permalink / raw)
To: Samuel Thibault; +Cc: Olaf Hering, xen-devel@lists.xen.org
On Tue, 2012-10-09 at 14:46 +0100, Samuel Thibault wrote:
> Olaf Hering, le Tue 09 Oct 2012 15:04:29 +0200, a écrit :
> > # HG changeset patch
> > # User Olaf Hering <olaf@aepfle.de>
> > # Date 1349787855 -7200
> > # Node ID 384714804b9b2a9742cc45dffaa43b749b85513b
> > # Parent 142e4577f5a9b95832b82f7b6d31fde1697cbe76
> > stubdom: fix error assignment in grub:load_module
> >
> > [ 1333s] mini-os.c: In function 'load_module':
> > [ 1333s] mini-os.c:244: warning: statement with no effect
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
APplied, thanks,
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-11 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-09 13:04 [PATCH] stubdom: fix error assignment in grub:load_module Olaf Hering
2012-10-09 13:46 ` Samuel Thibault
2012-10-11 9:21 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).