From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH] stubdom: fix error assignment in
 grub:load_module
Date: Tue, 9 Oct 2012 15:46:48 +0200
Message-ID: <20121009134648.GN6113@type.bordeaux.inria.fr>
References: <384714804b9b2a9742cc.1349787869@probook.site>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <384714804b9b2a9742cc.1349787869@probook.site>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Olaf Hering, le Tue 09 Oct 2012 15:04:29 +0200, a =E9crit :
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1349787855 -7200
> # Node ID 384714804b9b2a9742cc45dffaa43b749b85513b
> # Parent  142e4577f5a9b95832b82f7b6d31fde1697cbe76
> stubdom: fix error assignment in grub:load_module
> =

> [ 1333s] mini-os.c: In function 'load_module':
> [ 1333s] mini-os.c:244: warning: statement with no effect
> =

> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> diff -r 142e4577f5a9 -r 384714804b9b stubdom/grub/mini-os.c
> --- a/stubdom/grub/mini-os.c
> +++ b/stubdom/grub/mini-os.c
> @@ -241,7 +241,7 @@ load_module (char *module, char *arg)
>  =

>      if ((void*) (multiboot_next_module_header+1) - module_image > PAGE_S=
IZE) {
>          /* Too many modules */
> -        ERR_WONT_FIT;
> +        errnum =3D ERR_WONT_FIT;
>          return 0;
>      }
>  =

> =

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
> =


-- =

Samuel
/* Halley */

	(Halley's comment.)