From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 09/10] xen: balloon: use correct type for frame_list Date: Wed, 17 Oct 2012 13:32:49 -0400 Message-ID: <20121017173249.GA25260@phenom.dumpdata.com> References: <1350463138.2460.19.camel@zakaz.uk.xensource.com> <1350463157-5068-9-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Wed, Oct 17, 2012 at 06:28:35PM +0100, Stefano Stabellini wrote: > On Wed, 17 Oct 2012, Ian Campbell wrote: > > This is now a xen_pfn_t. > > > > Signed-off-by: Ian Campbell > > --- > > drivers/xen/balloon.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c > > index d7bd1b3..d6886d9 100644 > > --- a/drivers/xen/balloon.c > > +++ b/drivers/xen/balloon.c > > @@ -87,7 +87,7 @@ struct balloon_stats balloon_stats; > > EXPORT_SYMBOL_GPL(balloon_stats); > > > > /* We increase/decrease in batches which fit in a page */ > > -static unsigned long frame_list[PAGE_SIZE / sizeof(unsigned long)]; > > +static xen_pfn_t frame_list[PAGE_SIZE / sizeof(unsigned long)]; > > > > #ifdef CONFIG_HIGHMEM > > #define inc_totalhigh_pages() (totalhigh_pages++) > > I know that we agreed to this change but it still gives me the creeps. > I would love a comment either in the code or in the commit message, > explaining why it is safe to pass a xen_pfn_t (potentially 64 bit) to > set_phys_to_machine. I applied all the patches in this patchset except this one. Will apply once a new version is out.