From: Dave McCracken <dcm@mccr.org>
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Xen Developers List <xen-devel@lists.xensource.com>,
Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] Make restore work properly with PV superpage flag
Date: Thu, 18 Oct 2012 09:46:41 -0500 [thread overview]
Message-ID: <201210180946.41472.dcm@mccr.org> (raw)
In-Reply-To: <CAFLBxZbqRDOiyQO6NNDfTUqnPgwzJujtYEGPhaM=rJZaPMZBFQ@mail.gmail.com>
On Thursday, October 18, 2012, George Dunlap wrote:
> Looks good -- boy, when you know that all of your pages have to be
> superpages, it makes the logic a lot easier. :-) Unfortunately that's
> not the case for HVM guests, so we need to keep the complicated
> detection logic.
>
> I was trying to think of a way to make the "hvm" and "superpage" based
> on the desired behavior (e.g, "detect_superpages",
> "always_superpages", or something like that), rather than having to
> encode "!hvm && superpage" all over the place, but I think in the end
> the way you've written it is fine.
Yeah, I spent a lot of time trying to make some integrated way to do both
types of allocation, but finally gave up and kept the two code paths separate.
In the end I think it's cleaner that way.
Dave
next prev parent reply other threads:[~2012-10-18 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 17:32 [PATCH] Make restore work properly with PV superpage flag Dave McCracken
2012-10-18 10:05 ` Ian Campbell
2012-10-18 10:01 ` George Dunlap
2012-10-18 14:41 ` George Dunlap
2012-10-18 14:46 ` Dave McCracken [this message]
2012-11-12 17:04 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210180946.41472.dcm@mccr.org \
--to=dcm@mccr.org \
--cc=George.Dunlap@eu.citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).