From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave McCracken Subject: Re: [PATCH] Make restore work properly with PV superpage flag Date: Thu, 18 Oct 2012 09:46:41 -0500 Message-ID: <201210180946.41472.dcm@mccr.org> References: <20121012173222.31965.33368.sendpatchset@magnum.int.mccr.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Xen Developers List , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Thursday, October 18, 2012, George Dunlap wrote: > Looks good -- boy, when you know that all of your pages have to be > superpages, it makes the logic a lot easier. :-) Unfortunately that's > not the case for HVM guests, so we need to keep the complicated > detection logic. > > I was trying to think of a way to make the "hvm" and "superpage" based > on the desired behavior (e.g, "detect_superpages", > "always_superpages", or something like that), rather than having to > encode "!hvm && superpage" all over the place, but I think in the end > the way you've written it is fine. Yeah, I spent a lot of time trying to make some integrated way to do both types of allocation, but finally gave up and kept the two code paths separate. In the end I think it's cleaner that way. Dave