From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] ACPI/cpuidle: remove unused "power" field from Cx state data
Date: Fri, 2 Nov 2012 10:18:45 -0400 [thread overview]
Message-ID: <20121102141845.GA3413@konrad-lan.dumpdata.com> (raw)
In-Reply-To: <5093E1B602000078000A6105@nat28.tlf.novell.com>
On Fri, Nov 02, 2012 at 02:07:34PM +0000, Jan Beulich wrote:
> >>> On 02.11.12 at 14:55, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> > On Fri, Nov 02, 2012 at 01:12:05PM +0000, Jan Beulich wrote:
> >> It has never been used for anything, and Linux 3.7 doesn't propagate
> >> this information anymore.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >> ---
> >> Konrad, on the pv-ops side it may be better to pass zero rather than
> >> leaving the field completely uninitialized.
> >
> > I think this got taken care of by:
> >
> > commit c59687f8466df36633d937cc298aad465d704990
> > Author: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Date: Wed Sep 5 15:13:48 2012 +0200
> >
> > cpuidle / ACPI : remove power from acpi_processor_cx structure
> >
> > Remove the unused power field from struct struct acpi_processor_cx.
> >
> > [rjw: Modified changelog.]
>
> That's the commit I was referring to.
>
> > And the the xen_processor_cx is allocated using kcalloc which resets
> > everything to zero - so I think we are safe there.
>
> And that I didn't pay attention to - sorry for the noise then.
Oh no problem - Thank you for keeping me in the loop!
>
> Jan
>
next prev parent reply other threads:[~2012-11-02 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 13:12 [PATCH] ACPI/cpuidle: remove unused "power" field from Cx state data Jan Beulich
2012-11-02 13:55 ` Konrad Rzeszutek Wilk
2012-11-02 14:07 ` Jan Beulich
2012-11-02 14:18 ` Konrad Rzeszutek Wilk [this message]
2012-11-02 14:50 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102141845.GA3413@konrad-lan.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).