From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] ACPI/cpuidle: remove unused "power" field from Cx state data Date: Fri, 2 Nov 2012 10:18:45 -0400 Message-ID: <20121102141845.GA3413@konrad-lan.dumpdata.com> References: <5093D4B502000078000A606E@nat28.tlf.novell.com> <20121102135514.GC3038@konrad-lan.dumpdata.com> <5093E1B602000078000A6105@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5093E1B602000078000A6105@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Fri, Nov 02, 2012 at 02:07:34PM +0000, Jan Beulich wrote: > >>> On 02.11.12 at 14:55, Konrad Rzeszutek Wilk wrote: > > On Fri, Nov 02, 2012 at 01:12:05PM +0000, Jan Beulich wrote: > >> It has never been used for anything, and Linux 3.7 doesn't propagate > >> this information anymore. > >> > >> Signed-off-by: Jan Beulich > >> --- > >> Konrad, on the pv-ops side it may be better to pass zero rather than > >> leaving the field completely uninitialized. > > > > I think this got taken care of by: > > > > commit c59687f8466df36633d937cc298aad465d704990 > > Author: Daniel Lezcano > > Date: Wed Sep 5 15:13:48 2012 +0200 > > > > cpuidle / ACPI : remove power from acpi_processor_cx structure > > > > Remove the unused power field from struct struct acpi_processor_cx. > > > > [rjw: Modified changelog.] > > That's the commit I was referring to. > > > And the the xen_processor_cx is allocated using kcalloc which resets > > everything to zero - so I think we are safe there. > > And that I didn't pay attention to - sorry for the noise then. Oh no problem - Thank you for keeping me in the loop! > > Jan >