From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: "Fioravante, Matthew E." <Matthew.Fioravante@jhuapl.edu>
Cc: "Ian.Campbell@citrix.com" <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH VTPM 1/9] Disable -DGNT_DEBUG and -DGNTMAP_DEBUG
Date: Tue, 6 Nov 2012 00:34:52 +0100 [thread overview]
Message-ID: <20121105233452.GI16909@type.youpi.perso.aquilenet.fr> (raw)
In-Reply-To: <068F06DC4D106941B297C0C5F9F446EA48A1C7BA68@aplesstripe.dom1.jhuapl.edu>
Fioravante, Matthew E., le Fri 02 Nov 2012 09:19:34 -0400, a écrit :
> It happens in my vtpm domains because the drivers often create and release grant references. This patch isn't completely necessary. Do we want to have these debug prints in the default build?
Well, surely -DGNT_DEBUG doesn't produce any output :) We could however
drop it, since it only adds overhead to check something that is supposed
to be already working (and which is quite well tested nowadays).
About -DGNTMAP_DEBUG, which message are you getting printed a lot? Are
you running out of references in gntmap_find_free_entry, or using
gntmap_map_grant_refs a lot?
Samuel
next prev parent reply other threads:[~2012-11-05 23:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 20:33 [PATCH VTPM 1/9] Disable -DGNT_DEBUG and -DGNTMAP_DEBUG Matthew Fioravante
2012-11-01 20:33 ` [PATCH VTPM 2/9] add xenbus_read_uuid to mini-os Matthew Fioravante
2012-11-01 21:32 ` Samuel Thibault
2012-11-13 10:47 ` Ian Campbell
2012-11-01 20:33 ` [PATCH VTPM 3/9] add tpmfront, tpm_tis, and tpmback drivers " Matthew Fioravante
2012-11-13 10:48 ` Ian Campbell
2012-11-01 20:33 ` [PATCH VTPM 4/9] fix bug in lseek for mini-os Matthew Fioravante
2012-11-01 21:34 ` Samuel Thibault
2012-11-02 13:22 ` Fioravante, Matthew E.
2012-11-01 21:29 ` [PATCH VTPM 1/9] Disable -DGNT_DEBUG and -DGNTMAP_DEBUG Samuel Thibault
2012-11-02 13:19 ` Fioravante, Matthew E.
2012-11-05 23:34 ` Samuel Thibault [this message]
2012-11-06 14:59 ` Matthew Fioravante
2012-11-06 15:13 ` Samuel Thibault
2012-11-06 15:13 ` Samuel Thibault
2012-11-13 10:47 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121105233452.GI16909@type.youpi.perso.aquilenet.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=Ian.Campbell@citrix.com \
--cc=Matthew.Fioravante@jhuapl.edu \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).