From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Matthew Fioravante <matthew.fioravante@jhuapl.edu>,
"jeremy@goop.org" <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mail@srajiv.net" <mail@srajiv.net>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
Kent Yoder <key@linux.vnet.ibm.com>
Subject: Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver
Date: Thu, 8 Nov 2012 08:31:45 -0500 [thread overview]
Message-ID: <20121108133145.GC3081@phenom.dumpdata.com> (raw)
In-Reply-To: <1352364376.12977.93.camel@hastur.hellion.org.uk>
On Thu, Nov 08, 2012 at 09:46:16AM +0100, Ian Campbell wrote:
> > > >>+typedef struct tpmif_tx_request tpmif_tx_request_t;
> > > > checkpatch warned on this new typedef - please run through checkpatch
> > > >and fix up that stuff.
> > > tpmif.h has a couple of typedefs which do trigger checkpatch
> > > warnings. However it looks like the paradigm for xen is to have
> > > these interface/io/<dev>if.h files and all of them have typedefs. I
> > > think in this case the typedef should probably stay.
> > >
> > > Konrad your thoughts here?
> >
> > Rip them out plea
>
> This is somewhere that Linux coding style and Xen coding style differ,
> so the typedefs should be removed from the Linux copy of these
> interfaces to match the Linux coding style, but they should stay in the
> Xen side canonical copy though.
Yes. Sorry for not making that clear.
>
> Ian.
next prev parent reply other threads:[~2012-11-08 13:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 15:09 [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver Matthew Fioravante
2012-11-06 19:39 ` Konrad Rzeszutek Wilk
2012-11-07 14:05 ` Matthew Fioravante
2012-11-07 14:48 ` Kent Yoder
2012-11-07 16:07 ` Konrad Rzeszutek Wilk
2012-11-08 15:40 ` Fioravante, Matthew E.
2012-11-07 14:46 ` Kent Yoder
2012-11-07 18:14 ` Matthew Fioravante
2012-11-08 1:10 ` Konrad Rzeszutek Wilk
2012-11-08 8:46 ` [Xen-devel] " Ian Campbell
2012-11-08 13:31 ` Konrad Rzeszutek Wilk [this message]
2012-11-08 8:17 ` Jan Beulich
2012-11-08 15:28 ` Kent Yoder
2012-11-08 15:36 ` Fioravante, Matthew E.
2012-11-08 22:06 ` [tpmdd-devel] " Kent Yoder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121108133145.GC3081@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=key@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@srajiv.net \
--cc=matthew.fioravante@jhuapl.edu \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).