From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver Date: Thu, 8 Nov 2012 08:31:45 -0500 Message-ID: <20121108133145.GC3081@phenom.dumpdata.com> References: <1352128197-1539-1-git-send-email-matthew.fioravante@jhuapl.edu> <20121107144625.GA14628@ennui.austin.ibm.com> <509AA501.1090701@jhuapl.edu> <20121108011006.GC21302@phenom.dumpdata.com> <1352364376.12977.93.camel@hastur.hellion.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1352364376.12977.93.camel@hastur.hellion.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Ian Campbell Cc: Matthew Fioravante , "jeremy@goop.org" , "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" , "mail@srajiv.net" , "tpmdd-devel@lists.sourceforge.net" , Kent Yoder List-Id: xen-devel@lists.xenproject.org On Thu, Nov 08, 2012 at 09:46:16AM +0100, Ian Campbell wrote: > > > >>+typedef struct tpmif_tx_request tpmif_tx_request_t; > > > > checkpatch warned on this new typedef - please run through checkpatch > > > >and fix up that stuff. > > > tpmif.h has a couple of typedefs which do trigger checkpatch > > > warnings. However it looks like the paradigm for xen is to have > > > these interface/io/if.h files and all of them have typedefs. I > > > think in this case the typedef should probably stay. > > > > > > Konrad your thoughts here? > > > > Rip them out plea > > This is somewhere that Linux coding style and Xen coding style differ, > so the typedefs should be removed from the Linux copy of these > interfaces to match the Linux coding style, but they should stay in the > Xen side canonical copy though. Yes. Sorry for not making that clear. > > Ian.