xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
Subject: Re: PVH: libxl expertise...
Date: Wed, 14 Nov 2012 18:13:54 -0800	[thread overview]
Message-ID: <20121114181354.568ce2db@mantra.us.oracle.com> (raw)
In-Reply-To: <1352887110.26873.15.camel@zakaz.uk.xensource.com>

On Wed, 14 Nov 2012 09:58:30 +0000
Ian Campbell <Ian.Campbell@citrix.com> wrote:

Duuude!!! You owe me a beer next time we meet (was your code ;)), and I
ain't making it a cheap one :).

The problem is :

#define FEATURES_PVH "|writable_descriptor_tables" \
                    "|auto_translated_physmap" \
                    "|supervisor_mode_kernel" \
                    "|hvm_callback_vector"

ELFNOTE(Xen, XEN_ELFNOTE_FEATURES,       .asciz
"!writable_page_tables|pae_pgdir_above_4gb"FEATURES_PVH)


This is a .S file and not C, and it puts null char after _4gb. Fixed it
and now xc_dom_feature_translated() is returnig true. Whew! I'll send
konrad a patch.

On to the next one .............

thanks again,
Mukesh

  parent reply	other threads:[~2012-11-15  2:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-13  3:09 PVH: libxl expertise Mukesh Rathor
2012-11-13 10:00 ` Ian Campbell
2012-11-13 19:53   ` Mukesh Rathor
2012-11-14  1:21   ` Mukesh Rathor
2012-11-14  1:31     ` Mukesh Rathor
2012-11-14  9:58       ` Ian Campbell
2012-11-14 19:04         ` Mukesh Rathor
2012-11-15  0:29         ` Mukesh Rathor
2012-11-15  2:13         ` Mukesh Rathor [this message]
2012-11-15  8:47           ` Ian Campbell
2012-11-13 17:14 ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121114181354.568ce2db@mantra.us.oracle.com \
    --to=mukesh.rathor@oracle.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).