From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: PVH: libxl expertise...
Date: Wed, 14 Nov 2012 18:13:54 -0800
Message-ID: <20121114181354.568ce2db@mantra.us.oracle.com>
References: <20121112190934.5e702799@mantra.us.oracle.com>
	<1352800853.7491.22.camel@zakaz.uk.xensource.com>
	<20121113172138.1d3274d9@mantra.us.oracle.com>
	<20121113173138.61b21067@mantra.us.oracle.com>
	<1352887110.26873.15.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1352887110.26873.15.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 14 Nov 2012 09:58:30 +0000
Ian Campbell <Ian.Campbell@citrix.com> wrote:

Duuude!!! You owe me a beer next time we meet (was your code ;)), and I
ain't making it a cheap one :).

The problem is :

#define FEATURES_PVH "|writable_descriptor_tables" \
                    "|auto_translated_physmap" \
                    "|supervisor_mode_kernel" \
                    "|hvm_callback_vector"

ELFNOTE(Xen, XEN_ELFNOTE_FEATURES,       .asciz
"!writable_page_tables|pae_pgdir_above_4gb"FEATURES_PVH)


This is a .S file and not C, and it puts null char after _4gb. Fixed it
and now xc_dom_feature_translated() is returnig true. Whew! I'll send
konrad a patch.

On to the next one .............

thanks again,
Mukesh