From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH 09/14] xen: events: Remove redundant check on unsigned variable
Date: Fri, 16 Nov 2012 11:09:23 -0500 [thread overview]
Message-ID: <20121116160923.GP22320@phenom.dumpdata.com> (raw)
In-Reply-To: <1353048646-10935-10-git-send-email-tushar.behera@linaro.org>
On Fri, Nov 16, 2012 at 12:20:41PM +0530, Tushar Behera wrote:
> No need to check whether unsigned variable is less than 0.
>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> CC: Jeremy Fitzhardinge <jeremy@goop.org>
> CC: xen-devel@lists.xensource.com
> CC: virtualization@lists.linux-foundation.org
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> drivers/xen/events.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 4293c57..cadd7d1 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -216,7 +216,7 @@ static void xen_irq_info_pirq_init(unsigned irq,
> */
> static unsigned int evtchn_from_irq(unsigned irq)
> {
> - if (unlikely(WARN(irq < 0 || irq >= nr_irqs, "Invalid irq %d!\n", irq)))
> + if (unlikely(WARN(irq >= nr_irqs, "Invalid irq %d!\n", irq)))
> return 0;
>
> return info_for_irq(irq)->evtchn;
> --
> 1.7.4.1
next prev parent reply other threads:[~2012-11-16 16:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 6:50 [PATCH 00/14] Modify signed comparisons of unsigned variables Tushar Behera
2012-11-16 6:50 ` [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable Tushar Behera
2012-11-16 9:16 ` Ian Campbell
2012-12-28 5:15 ` Tushar Behera
2012-12-28 10:41 ` [Xen-devel] " Wei Liu
2013-01-02 21:40 ` Konrad Rzeszutek Wilk
2012-11-16 6:50 ` [PATCH 09/14] xen: events: " Tushar Behera
2012-11-16 16:09 ` Konrad Rzeszutek Wilk [this message]
2012-11-16 16:53 ` Jeremy Fitzhardinge
2012-11-19 3:52 ` Tushar Behera
2012-11-19 10:31 ` Ian Campbell
2012-11-19 11:00 ` [Xen-devel] " Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116160923.GP22320@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=tushar.behera@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).