From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH] xen/arm: build as zImage Date: Fri, 23 Nov 2012 16:38:37 +0000 Message-ID: <20121123163837.GB97222@ocelot.phlegethon.org> References: <1353686042.16973.19.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: Anthony Perard , "xen-devel@lists.xensource.com" , Ian Campbell List-Id: xen-devel@lists.xenproject.org At 16:14 +0000 on 23 Nov (1353687242), Stefano Stabellini wrote: > On Fri, 23 Nov 2012, Ian Campbell wrote: > > If that doesn't work then this constant is actually in > > xen/arch/arm/Makefile too and for the same reason: > > # XXX: VE model loads by VMA so instead of > > # making a proper ELF we link with LMA == VMA and adjust crudely > > $(OBJCOPY) --change-addresses +0x80000000 $< $@ > > $(STRIP) $@ > > > > How about making this CONFIG_PHYSICAL_LOCAL_ADDR and plumbing through > > like we do with CONFIG_DTB_FILE? Good idea. In fact it already exists, as CONFIG_LOAD_ADDRESS in config/arm.mk, and should probably be used here, with a bit of $(()) magic to get the right offset. > Yeah, I was thinking about that. > However in this case we would want to set the default somewhere, rather > than forcing the user to specify it. > Also we would need to export CONFIG_PHYSICAL_LOCAL_ADDR to a generated > header file somewhere. Do you have any suggestions on where? We could pass it with -D when we're processing head.S, as we already do for xen.lds.S. (Though the XEN_PHYS_START name (un)used in xen.lds.S should probably also be XEN_LOAD_ADDRESS). Tim.