From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Wilson Subject: Re: [PATCH] README: add Pixman as build dependency Date: Mon, 26 Nov 2012 18:59:41 -0800 Message-ID: <20121127025938.GA3854@u109add4315675089e695.ant.amazon.com> References: <50B357A7.6050905@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: "xen-devel@lists.xensource.com" , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org On Mon, Nov 26, 2012 at 07:35:43PM +0000, Stefano Stabellini wrote: > On Mon, 26 Nov 2012, Roger Pau Monne wrote: > > On 23/11/12 13:51, Stefano Stabellini wrote: > > > Signed-off-by: Stefano Stabellini > > > > > > diff --git a/README b/README > > > index 21a81b2..88300df 100644 > > > --- a/README > > > +++ b/README > > > @@ -51,6 +51,7 @@ provided by your OS distributor: > > > * Development install of libaio (e.g. libaio-dev) version 0.3.107 or > > > greater. Set CONFIG_SYSTEM_LIBAIO in .config if this is not available. > > > * Development install of GLib v2.0 (e.g. libglib2.0-dev) > > > + * Development install of Pixman (e.g. libpixman-1-dev) > > > > Should we add a configure test for Pixman? I guess this is needed by Qemu. > > Yes, it is a QEMU dependency. > > Is it actually a good idea to replicate all the configure checks done by > QEMU's configure script in the Xen configure script? I don't think it's a good idea to duplicate checks. We should call qemu's ./configure early, perhaps from our ./configure, and make sure that errors are clearly propagated and messaged to the user. Matt