From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH RFC] stubdom: Change vTPM shared page ABI Date: Fri, 30 Nov 2012 11:11:40 -0500 Message-ID: <20121130161134.GA5420@localhost.localdomain> References: <1353427860-17330-1-git-send-email-dgdegra@tycho.nsa.gov> <068F06DC4D106941B297C0C5F9F446EA48B7649849@aplesstripe.dom1.jhuapl.edu> <1353668646.13542.228.camel@zakaz.uk.xensource.com> <20121128204630.GB3479@phenom.dumpdata.com> <50B68EC3.1070803@jhuapl.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <50B68EC3.1070803@jhuapl.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Matthew Fioravante Cc: Daniel De Graaf , Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Wed, Nov 28, 2012 at 05:22:59PM -0500, Matthew Fioravante wrote: > On 11/28/2012 03:46 PM, Konrad Rzeszutek Wilk wrote: > >On Fri, Nov 23, 2012 at 11:04:06AM +0000, Ian Campbell wrote: > >>On Tue, 2012-11-20 at 16:16 +0000, Fioravante, Matthew E. wrote: > >>>This was something I've been wanting to do for a while so I'm very > >>>happy you went ahead and fixed it yourself. Once you submit the linux > >>>version I'll test it on my system. > >>> > >>>Acked by: Matthew Fioravante > >>Do we need to synchronise with anything else (Linux drivers?) or I can I > >>just throw this into the tree once it is done? > >> > >>Are we hanging any existing users of the tpm stuff out to dry? Could we > >>get a feature-protocol-v2 flag in xenstore so users at least get an > >>error message from either the front or backend to give a hint why it > >>isn't working? > >We could cop out and just name this new driver differently. Then > >we would not have to deal with the older ones. > I've already done that with my patch on the linux mailing list. The > old frontend driver name was tpm_xenu.ko, the new one is > xen-tpmfront.ko. I meant the XenBus directory name. It is 'vtpm' - if it was called 'vtpm2' we would avoid the "older" drivers from even seeing this one. > > > >>> void send_response(tpmcmd_t* cmd, tpmif_t* tpmif) { > >>>- tpmif_tx_request_t* tx; > >>>- int offset; > >>>- int i; > >>>- uint32_t domid; > >>>- int tocopy; > >>>+ vtpm_shared_page_t* shr; > >>>+ unsigned int offset; > >>> int flags; > >>>+#ifdef TPMBACK_PRINT_DEBUG > >>>+int i; > >>>+#endif > >>Dodgy indentation? (I saw a bunch of these) > >> > >>>- * Copyright (c) 2005, IBM Corporation > >>>- * > >>>- * Author: Stefan Berger, stefanb@us.ibm.com > >>>- * Grant table support: Mahadevan Gomathisankaran > >>Did you really remove everything these guys wrote? > >> > >>>- * This code has been derived from tools/libxc/xen/io/netif.h > >>>- * > >>>- * Copyright (c) 2003-2004, Keir Fraser > >>I guess I can buy this bit no longer being true given that you reworked > >>the whole protocol. > >> > >>Ian > >> > >> > >>_______________________________________________ > >>Xen-devel mailing list > >>Xen-devel@lists.xen.org > >>http://lists.xen.org/xen-devel > >> > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel