From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Keir Fraser <keir.xen@gmail.com>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>, xen-devel@lists.xen.org
Subject: [PATCH] mini-os: drop shutdown variables when CONFIG_XENBUS=n
Date: Tue, 4 Dec 2012 01:27:11 +0100 [thread overview]
Message-ID: <20121204002711.GO6055@type.youpi.perso.aquilenet.fr> (raw)
In-Reply-To: <CCDF6781.464C6%keir.xen@gmail.com>
Shutdown variables are meaningless when CONFIG_XENBUS=n since no
shutdown event will ever happen. Better make sure that no code tries to
use it and never get the hoped shutdown event.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
diff -r 29247e44df47 extras/mini-os/kernel.c
--- a/extras/mini-os/kernel.c Fri Nov 30 21:51:17 2012 +0000
+++ b/extras/mini-os/kernel.c Tue Dec 04 01:24:51 2012 +0100
@@ -48,9 +48,11 @@
uint8_t xen_features[XENFEAT_NR_SUBMAPS * 32];
+#ifdef CONFIG_XENBUS
unsigned int do_shutdown = 0;
unsigned int shutdown_reason;
DECLARE_WAIT_QUEUE_HEAD(shutdown_queue);
+#endif
void setup_xen_features(void)
{
prev parent reply other threads:[~2012-12-04 0:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 20:44 [PATCH] mini-os: shutdown_thread depends on xenbus Daniel De Graaf
2012-11-30 23:13 ` Samuel Thibault
2012-12-01 7:51 ` Keir Fraser
2012-12-04 0:27 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121204002711.GO6055@type.youpi.perso.aquilenet.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=dgdegra@tycho.nsa.gov \
--cc=keir.xen@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).