From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH V5] X86/vMCE: handle broken page with regard to migration Date: Thu, 6 Dec 2012 10:08:18 +0000 Message-ID: <20121206100818.GF82725@ocelot.phlegethon.org> References: <75d16e26926c873480ab.1354758907@ljsromley.bj.intel.com> <1354786255.17165.48.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1354786255.17165.48.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Liu Jinsong , George Dunlap , "xen-devel@lists.xensource.com" , Ian Jackson , "JBeulich@suse.com" List-Id: xen-devel@lists.xenproject.org At 09:30 +0000 on 06 Dec (1354786255), Ian Campbell wrote: > On Thu, 2012-12-06 at 01:55 +0000, Liu Jinsong wrote: > > At the sender > > xc_domain_save has a key point: 'to query the types of all the pages > > with xc_get_pfn_type_batch' > > 1) if broken page occur before the key point, migration will be fine > > since proper pfn_type and pfn number will be transferred to the > > target and then take appropriate action; > > 2) if broken page occur after the key point, whole system will crash > > and no need care migration any more; > > > > At the target > > Target will populates pages for guest. As for the case of broken page, > > we prefer to keep the type of the page for the sake of seamless migration. > > Target will set p2m as p2m_ram_broken for broken page. If guest access > > the broken page again it will kill itself as expected. > > > > Patch version history: > > V5: > > - remove extra check at the last iteration > > - remove marking broken page to dirty bitmap > > I'm not totally convinced that this second one isn't required, but > what's here is correct as far as it goes. > > Acked-by: Ian Campbell > > If someone from the hypervisor side wants to re-ack I'll apply (it > doesn't look to have changed all that much to me, but I don't want to > presume to take it). Acked-by: Tim Deegan