From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [PVH]: Help: msi.c
Date: Fri, 14 Dec 2012 12:08:36 -0800
Message-ID: <20121214120836.6ec4ad4a@mantra.us.oracle.com>
References: <20121207174636.49c4f7eb@mantra.us.oracle.com>
	<50C5BCD602000078000AF51A@nat28.tlf.novell.com>
	<20121210184311.4fc11316@mantra.us.oracle.com>
	<alpine.DEB.2.02.1212111208260.17523@kaball.uk.xensource.com>
	<20121212171523.332a0a89@mantra.us.oracle.com>
	<20121212174312.68146c02@mantra.us.oracle.com>
	<50C9BF1E02000078000B00FC@nat28.tlf.novell.com>
	<alpine.DEB.2.02.1212131216190.17523@kaball.uk.xensource.com>
	<50C9E88F02000078000B02A1@nat28.tlf.novell.com>
	<alpine.DEB.2.02.1212131409040.17523@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1212131409040.17523@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>, Jan Beulich <JBeulich@suse.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 13 Dec 2012 14:25:16 +0000
Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:

> On Thu, 13 Dec 2012, Jan Beulich wrote:
> > >>> On 13.12.12 at 13:19, Stefano Stabellini
> > >>> <stefano.stabellini@eu.citrix.com>
> > wrote:
> > > On Thu, 13 Dec 2012, Jan Beulich wrote:
> > >> >>> On 13.12.12 at 02:43, Mukesh Rathor
> > >> >>> <mukesh.rathor@oracle.com> wrote:
> 
> Actually I think that you might be right: just looking at the code it
> seems that the mask bits get written to the table once as part of the
> initialization process:
> 
> pci_enable_msix -> msix_capability_init -> msix_program_entries
> 
> Unfortunately msix_program_entries is called few lines after
> arch_setup_msi_irqs, where we call PHYSDEVOP_map_pirq to map the MSI
> as a pirq.
> However after that is done, all the masking/unmask is done via
> irq_mask that we handle properly masking/unmasking the corresponding
> event channels.
> 
> 
> Possible solutions on top of my head:
> 
> - in msix_program_entries instead of writing to the table directly
> (__msix_mask_irq), call desc->irq_data.chip->irq_mask(); 
> 
> - replace msix_program_entries with arch_msix_program_entries, but it
> would probably be unpopular.


Can you or Jan or somebody please take that over? I can focus on other
PVH things then and try to get a patch in asap.

Thanks,
Mukesh