From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH 3/5] xen: arm: head.S PT_DEV is unused, drop and rename PT_DEV_L3 Date: Thu, 20 Dec 2012 11:21:29 +0000 Message-ID: <20121220112129.GC80837@ocelot.phlegethon.org> References: <1355849351.14620.274.camel@zakaz.uk.xensource.com> <1355849376-26652-3-git-send-email-ian.campbell@citrix.com> <1355912423.14620.291.camel@zakaz.uk.xensource.com> <20121219104932.GA65599@ocelot.phlegethon.org> <1355916124.14620.328.camel@zakaz.uk.xensource.com> <1355928840.14620.432.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1355928840.14620.432.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org At 14:54 +0000 on 19 Dec (1355928840), Ian Campbell wrote: > On Wed, 2012-12-19 at 11:22 +0000, Ian Campbell wrote: > > On Wed, 2012-12-19 at 10:49 +0000, Tim Deegan wrote: > > > At 10:20 +0000 on 19 Dec (1355912423), Ian Campbell wrote: > > > > On Tue, 2012-12-18 at 18:33 +0000, Stefano Stabellini wrote: > > > > > On Tue, 18 Dec 2012, Ian Campbell wrote: > > > > > > This shortens an overly long line. > > > > > > > > > > > > Signed-off-by: Ian Campbell > > > > > > > > > > honestly I would rather keep it because it has been quite useful for > > > > > debugging in the past once all the bugs have been fixed (TM) then we can > > > > > remove it ;-) > > > > > > > > Can you not just re-add it for debug? > > > > > > > > I mostly just want to get rid of the overlong line, I could nuke the > > > > spaces from the comment (in all of them, not just this one) instead? > > > > > > Could you just remove the 'lev3: ' from the comment, pulling it in to > > > exactly 80 chars? Your' added 'second level' and 'third level' make it > > > redundant, and I'd rather not lose the spaces in the comments. > > > > I think that makes it exactly 80 characters, which is probably ok. > > It ends up as below, exactly 80 characters long. I think it's probably > not worth it. OK, how's this? arm: trim pagetable flag definitions to fit in 80 characters Signed-off-by: Tim Deegan diff -r 6f5c96855a9e xen/arch/arm/arm32/head.S --- a/xen/arch/arm/arm32/head.S Thu Dec 20 11:00:32 2012 +0100 +++ b/xen/arch/arm/arm32/head.S Thu Dec 20 11:19:53 2012 +0000 @@ -24,10 +24,10 @@ #define ZIMAGE_MAGIC_NUMBER 0x016f2818 -#define PT_PT 0xe7f /* nG=1, AF=1, SH=10, AP=01, NS=1, ATTR=111, T=1, P=1 */ -#define PT_MEM 0xe7d /* nG=1, AF=1, SH=10, AP=01, NS=1, ATTR=111, T=0, P=1 */ -#define PT_DEV 0xe71 /* nG=1, AF=1, SH=10, AP=01, NS=1, ATTR=100, T=0, P=1 */ -#define PT_DEV_L3 0xe73 /* lev3: nG=1, AF=1, SH=10, AP=01, NS=1, ATTR=100, T=1, P=1 */ +#define PT_PT 0xe7f /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=111 T=1 P=1 */ +#define PT_MEM 0xe7d /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=111 T=0 P=1 */ +#define PT_DEV 0xe71 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=0 P=1 */ +#define PT_DEV_L3 0xe73 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=1 P=1 */ #define PT_UPPER(x) (PT_##x & 0xf00) #define PT_LOWER(x) (PT_##x & 0x0ff)