From: Tim Deegan <tim@xen.org>
To: Xiantao Zhang <xiantao.zhang@intel.com>
Cc: eddie.dong@intel.com, keir@xen.org, JBeulich@suse.com,
jun.nakajima@intel.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v3 06/10] nEPT: Sync PDPTR fields if L2 guest in PAE paging mode
Date: Thu, 20 Dec 2012 12:18:30 +0000 [thread overview]
Message-ID: <20121220121830.GI80837@ocelot.phlegethon.org> (raw)
In-Reply-To: <1356018231-26440-7-git-send-email-xiantao.zhang@intel.com>
At 23:43 +0800 on 20 Dec (1356047027), Xiantao Zhang wrote:
> From: Zhang Xiantao <xiantao.zhang@intel.com>
>
> For PAE L2 guest, GUEST_DPPTR registers needs to be synced for each virtual
> vmentry.
> Signed-off-by: Zhang Xiantao <xiantao.zhang@intel.com>
Apart from the whitespace mangling that Jan pointed out,
Acked-by: Tim Deegan <tim@xen.org>
> ---
> xen/arch/x86/hvm/vmx/vvmx.c | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c
> index 2ae6f6a..1f7de7a 100644
> --- a/xen/arch/x86/hvm/vmx/vvmx.c
> +++ b/xen/arch/x86/hvm/vmx/vvmx.c
> @@ -826,7 +826,14 @@ static void load_shadow_guest_state(struct vcpu *v)
> vvmcs_to_shadow(vvmcs, CR0_GUEST_HOST_MASK);
> vvmcs_to_shadow(vvmcs, CR4_GUEST_HOST_MASK);
>
> - /* TODO: PDPTRs for nested ept */
> + if ( nvmx_ept_enabled(v) && hvm_pae_enabled(v) &&
> + (v->arch.hvm_vcpu.guest_efer & EFER_LMA) ) {
> + vvmcs_to_shadow(vvmcs, GUEST_PDPTR0);
> + vvmcs_to_shadow(vvmcs, GUEST_PDPTR1);
> + vvmcs_to_shadow(vvmcs, GUEST_PDPTR2);
> + vvmcs_to_shadow(vvmcs, GUEST_PDPTR3);
> + }
> +
> /* TODO: CR3 target control */
> }
>
> --
> 1.7.1
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-12-20 12:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 15:43 [PATCH v3 00/10] Nested VMX: Add virtual EPT & VPID support to L1 VMM Xiantao Zhang
2012-12-20 13:55 ` Tim Deegan
2012-12-21 1:27 ` Zhang, Xiantao
2012-12-20 15:43 ` [PATCH v3 01/10] nestedhap: Change hostcr3 and p2m->cr3 to meaningful words Xiantao Zhang
2012-12-20 12:11 ` Tim Deegan
2012-12-20 15:43 ` [PATCH v3 02/10] nestedhap: Change nested p2m's walker to vendor-specific Xiantao Zhang
2012-12-20 15:43 ` [PATCH v3 03/10] nested_ept: Implement guest ept's walker Xiantao Zhang
2012-12-20 12:51 ` Tim Deegan
2012-12-24 9:01 ` Zhang, Xiantao
2013-01-10 11:19 ` Tim Deegan
2012-12-20 15:43 ` [PATCH v3 04/10] EPT: Make ept data structure or operations neutral Xiantao Zhang
2012-12-20 13:01 ` Tim Deegan
2012-12-20 15:43 ` [PATCH v3 05/10] nEPT: Try to enable EPT paging for L2 guest Xiantao Zhang
2012-12-20 15:43 ` [PATCH v3 06/10] nEPT: Sync PDPTR fields if L2 guest in PAE paging mode Xiantao Zhang
2012-12-20 9:39 ` Jan Beulich
2012-12-20 12:18 ` Tim Deegan [this message]
2012-12-20 15:43 ` [PATCH v3 07/10] nEPT: Use minimal permission for nested p2m Xiantao Zhang
2012-12-20 13:10 ` Tim Deegan
2012-12-20 15:43 ` [PATCH v3 08/10] nEPT: handle invept instruction from L1 VMM Xiantao Zhang
2012-12-20 9:54 ` Jan Beulich
2012-12-21 1:14 ` Zhang, Xiantao
2012-12-20 15:43 ` [PATCH v3 09/10] nVMX: virutalize VPID capability to nested VMM Xiantao Zhang
2012-12-20 9:56 ` Jan Beulich
2012-12-20 15:43 ` [PATCH v3 10/10] nEPT: expost EPT & VPID capablities to L1 VMM Xiantao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220121830.GI80837@ocelot.phlegethon.org \
--to=tim@xen.org \
--cc=JBeulich@suse.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).