From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Deegan <tim@xen.org>
Subject: Re: [PATCH v3 06/10] nEPT: Sync PDPTR fields if L2
	guest in PAE paging mode
Date: Thu, 20 Dec 2012 12:18:30 +0000
Message-ID: <20121220121830.GI80837@ocelot.phlegethon.org>
References: <1356018231-26440-1-git-send-email-xiantao.zhang@intel.com>
	<1356018231-26440-7-git-send-email-xiantao.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1356018231-26440-7-git-send-email-xiantao.zhang@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Xiantao Zhang <xiantao.zhang@intel.com>
Cc: eddie.dong@intel.com, keir@xen.org, JBeulich@suse.com, jun.nakajima@intel.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

At 23:43 +0800 on 20 Dec (1356047027), Xiantao Zhang wrote:
> From: Zhang Xiantao <xiantao.zhang@intel.com>
> 
> For PAE L2 guest, GUEST_DPPTR registers needs to be synced for each virtual
> vmentry.
> Signed-off-by: Zhang Xiantao <xiantao.zhang@intel.com>

Apart from the whitespace mangling that Jan pointed out, 

Acked-by: Tim Deegan <tim@xen.org>

> ---
>  xen/arch/x86/hvm/vmx/vvmx.c |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c
> index 2ae6f6a..1f7de7a 100644
> --- a/xen/arch/x86/hvm/vmx/vvmx.c
> +++ b/xen/arch/x86/hvm/vmx/vvmx.c
> @@ -826,7 +826,14 @@ static void load_shadow_guest_state(struct vcpu *v)
>      vvmcs_to_shadow(vvmcs, CR0_GUEST_HOST_MASK);
>      vvmcs_to_shadow(vvmcs, CR4_GUEST_HOST_MASK);
>  
> -    /* TODO: PDPTRs for nested ept */
> +    if ( nvmx_ept_enabled(v) && hvm_pae_enabled(v) &&
> +                    (v->arch.hvm_vcpu.guest_efer & EFER_LMA) ) {
> +	    vvmcs_to_shadow(vvmcs, GUEST_PDPTR0);
> +	    vvmcs_to_shadow(vvmcs, GUEST_PDPTR1);
> +	    vvmcs_to_shadow(vvmcs, GUEST_PDPTR2);
> +	    vvmcs_to_shadow(vvmcs, GUEST_PDPTR3);
> +    }
> +
>      /* TODO: CR3 target control */
>  }
>  
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel