From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Keir Fraser <keir.xen@gmail.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
"stefano.stabellini@eu.citrix.com"
<stefano.stabellini@eu.citrix.com>
Subject: Re: PVH update....
Date: Thu, 10 Jan 2013 17:11:55 -0800 [thread overview]
Message-ID: <20130110171155.1cf7febe@mantra.us.oracle.com> (raw)
In-Reply-To: <CD141F83.48B1C%keir.xen@gmail.com>
On Thu, 10 Jan 2013 07:34:27 +0000
Keir Fraser <keir.xen@gmail.com> wrote:
> On 10/01/2013 02:20, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote:
>
> This one's not rocket science, Mukesh. The hypervisor stack is 8kB,
> and construct_dom0() is trying to allocate a stack frame bigger than
> 8kB. Debug builds enforce the 8kB limit with guard pages. You will
> actually be crashing on the first stack writing instruction after the
> subq, but double fault is imprecise (in fact reported cs:eip is
> undefined for a double fault).
Thanks Keir. Of course that was my first thought, and I tried confirming
it with debug code in PF handler. When I noticed PF was not happening,
I started to think it must be something else combined with the fact
that the subq man page doesnt' say anything about RSP special case,
and it's just decrementing it, and not accessing it. Anyways, the
whole x86 is a rocket to me :)...
> You're allocating a ridiculously big local variable on
> construct_dom0's stack. So just don't do that.
Yup, I accidentally was allocating a large char array on stack. Fixed.
Thanks,
Mukesh
next prev parent reply other threads:[~2013-01-11 1:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 2:37 PVH update Mukesh Rathor
2013-01-09 2:50 ` Mukesh Rathor
2013-01-10 2:20 ` Mukesh Rathor
2013-01-10 7:34 ` Keir Fraser
2013-01-11 1:11 ` Mukesh Rathor [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-09 0:59 Mukesh Rathor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110171155.1cf7febe@mantra.us.oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Xen-devel@lists.xensource.com \
--cc=keir.xen@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).