Re: [RFC PATCH 2/16]: PVH xen: add XENMEM_add_to_physmap_range

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Sat, 12 Jan 2013 07:51:29 +0000
Keir Fraser <keir.xen@gmail.com> wrote:

> On 12/01/2013 01:28, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote:
> 
> > In this patch we add a new function xenmem_add_to_physmap_range(),
> > and change xenmem_add_to_physmap_once parameters so it can be
> > called from xenmem_add_to_physmap_range. There is no PVH specific
> > change here.
> > 
> > BTW, there are 16 patches and not 15. Sorry, corrected the subject.
> > 
> > Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
> > 
> > 
> > diff -r 278d7a933d88 -r ede1afe68962 xen/arch/x86/mm.c
> > --- a/xen/arch/x86/mm.c Fri Jan 11 16:19:40 2013 -0800
> > +++ b/xen/arch/x86/mm.c Fri Jan 11 16:20:38 2013 -0800
> > @@ -4218,8 +4218,8 @@ static int handle_iomem_range(unsigned l
> >  }
> >  
> >  static int xenmem_add_to_physmap_once(
> > -    struct domain *d,
> > -    const struct xen_add_to_physmap *xatp)
> > +    struct domain *d, uint16_t xatp_space, domid_t foreign_domid,
> > +    unsigned long xatp_idx, unsigned long xatp_gpfn)
> 
> The new caller should pack these arguments into a xen_add_to_physmap
> struct like all the others do. Don't atomise struct arguments like
> this, it's gross.
> 
>  -- Keir
> 

Ok, done.