From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: VMX status report. Xen:26323 & Dom0:3.7.1
Date: Mon, 14 Jan 2013 16:21:07 -0500
Message-ID: <20130114212107.GC7050@phenom.dumpdata.com>
References: <50EE908602000078000B44CE@nat28.tlf.novell.com>
	<D01C8DC1-D135-41E0-967A-FD2887E2604E@gridcentric.ca>
	<50EFDC8802000078000B4AC2@nat28.tlf.novell.com>
	<750FD2DB-E7A5-4038-9274-2CBAF2B4027C@gridcentric.ca>
	<50F40F42.5020807@citrix.com>
	<65B8802C-FE47-43CB-87EF-B168F57FF6DA@gmail.com>
	<50F42C6A.2080702@citrix.com>
	<50F43CFF02000078000B577F@nat28.tlf.novell.com>
	<50F42F32.9030003@citrix.com>
	<553DDB51-A606-4640-BEAE-AEE96B039F8C@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <553DDB51-A606-4640-BEAE-AEE96B039F8C@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andres Lagar-Cavilla <andres.lagarcavilla@gmail.com>
Cc: Yongjie Ren <yongjie.ren@intel.com>, Ian Campbell <Ian.Campbell@citrix.com>, AndresLagar-Cavilla <andres@lagarcavilla.org>, Andres Lagar-Cavilla <andreslc@gridcentric.ca>, xen-devel <xen-devel@lists.xen.org>, Chao Zhou <chao.zhou@intel.com>, Jan Beulich <JBeulich@suse.com>, Mats Petersson <mats.petersson@citrix.com>, Yan Dai <yan.dai@intel.com>, YongweiX Xu <yongweix.xu@intel.com>, SongtaoX Liu <songtaox.liu@intel.com>, David Vrabel <david.vrabel@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, Jan 14, 2013 at 11:19:18AM -0500, Andres Lagar-Cavilla wrote:
> On Jan 14, 2013, at 11:15 AM, David Vrabel <david.vrabel@citrix.com> wrote:
> 
> > On 14/01/13 16:14, Jan Beulich wrote:
> >>>>> On 14.01.13 at 17:03, David Vrabel <david.vrabel@citrix.com> wrote:
> >>> On 14/01/13 15:06, Andres Lagar-Cavilla wrote:
> >>>> @@ -288,7 +289,19 @@ static int mmap_batch_fn(void *data, void *state)
> >>>> 					 &cur_page);
> >>>> 
> >>>> 	/* Store error code for second pass. */
> >>>> -	*(st->err++) = ret;
> >>>> +	if (st->version == 1) {
> >>>> +		if (ret < 0) {
> >>>> +			/*
> >>>> +			 * V1 encodes the error codes in the 32bit top nibble of the
> >>>> +			 * mfn (with its known limitations vis-a-vis 64 bit callers).
> >>>> +			 */
> >>>> +			*mfnp |= (ret == -ENOENT) ?
> >>>> +						PRIVCMD_MMAPBATCH_PAGED_ERROR :
> >>>> +						PRIVCMD_MMAPBATCH_MFN_ERROR;
> >>> 
> >>> You also need to clear the top nibble on success (ret >= 0) so large
> >>> PFNs with the top nibble already set don't give false positives of errors.
> >> 
> >> Not really - that's what v2 was added for (the caller, unless
> >> keeping a second array with the original MFNs, wouldn't be able
> >> to match things up in that case).
> > 
> > Ok, I can agree with that.
> 
> Ok, cool, thanks David. Jan, Konrad, is the last patch sent this (EST) morning decent enough?


Hm, I am not seeing it in my mailbox. Was I on the 'To' or 'CC' list?