From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 4/4] review For Oracle bug 14470382
Date: Fri, 18 Jan 2013 09:45:03 +0300
Message-ID: <20130118064503.GJ16282@mwanda>
References: <50F8A979.6010709@oracle.com>
 <50F8AC1C.3060300@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <50F8AC1C.3060300@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: jianhai luan <jianhai.luan@oracle.com>
Cc: gmarsden_org_ww@oracle.com, LINUX-UEK_WW@oracle.com, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Fri, Jan 18, 2013 at 09:57:48AM +0800, jianhai luan wrote:
> +/**
> + * By Connected->Connected transition, netfront will watch the change and
> + * send gratuitous ARP.
> + */
> +static void notify_front_arping(struct xenbus_device *dev)
> +{
> +	struct xenbus_transaction xbt;
> +	int err;
> +
> +	if (xenbus_read_driver_state(dev->nodename) != XenbusStateConnected)
> +		return;
> +
> +again:
> +	err = xenbus_transaction_start(&xbt);
> +	if (err) {
> +		printk(KERN_ALERT "Error starting transaction");
> +		return;
> +	}
> +
> +	err = xenbus_printf(xbt, dev->nodename, "state", "%d", dev->state);
> +	if(err) {
> +		printk(KERN_ALERT "Error writing the state");
> +		xenbus_transaction_end(xbt, 1);
> +		return;
> +	}
> +	
> +	err = xenbus_transaction_end(xbt, 0);
> +	if (err == -EAGAIN)
> +		goto again;

Why would we get a -EAGAIN here?  My reading says that it would have
to come as the msg->body from the XenServer.  I would be tempted to
just ignore those errors.

(I don't know anything about Xen though, so I'm probably full of
crap).

regards,
dan carpenter