From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [RFC PATCH 12/16]: PVH xen: return PVH features
 during creation, etc...
Date: Fri, 18 Jan 2013 12:41:02 -0800
Message-ID: <20130118124102.33622f00@mantra.us.oracle.com>
References: <20130111180736.36c662d6@mantra.us.oracle.com>
	<50F4060C02000078000B5453@nat28.tlf.novell.com>
	<20130117153617.203b1aeb@mantra.us.oracle.com>
	<20130117182903.7bcb8da6@mantra.us.oracle.com>
	<50F9228502000078000B7354@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <50F9228502000078000B7354@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, 18 Jan 2013 09:23:01 +0000
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 18.01.13 at 03:29, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> > Done. No other callers of prop_page_fault for PVH. So are you OK
> > with something like this:
> > 
> > static noinline int vmxit_invalid_op(struct cpu_user_regs *regs)
> > {
> >     ulong addr=0;
> > 
> >     if ( guest_kernel_mode(current, regs) ||
> >          (addr = emulate_forced_invalid_op(regs)) == 0 )
> 
> Actually, on a second thought that depends on whether you want
> to be able to build kernels that can run both PV and PVH. If so,
> you may need to emulate this even for the guest kernel.

Actually, I changed linux code so that PVH paths will only go 
thru native_cpuid(). So we can leave this as is to discourage
future XEN_EMULATE_PREFIX. Sound good? In PV mode it will not be 
running in HVM container, hence not go thru this path.


> >     if ( is_pvh_vcpu(current) )
> >         regs->eip = eip;
> >     else
> >         instruction_done(regs, eip, 0);
> 
> Why can't you use instruction_done() (or make it fit your needs,
> so that other code wanting to use it wouldn't need similar special
> casing)?

Sure, NP. Done.

Thanks,
Mukesh