From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [RFC PATCH 3/16]: PVH xen: Add PHYSDEVOP_map_iomem
Date: Thu, 24 Jan 2013 17:03:50 -0800
Message-ID: <20130124170350.7a0afe31@mantra.us.oracle.com>
References: <20130111173243.2438c22a@mantra.us.oracle.com>
	<20130124150629.GD20551@ocelot.phlegethon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130124150629.GD20551@ocelot.phlegethon.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tim Deegan <tim@xen.org>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 24 Jan 2013 15:06:29 +0000
Tim Deegan <tim@xen.org> wrote:

> At 17:32 -0800 on 11 Jan (1357925563), Mukesh Rathor wrote:
>DEFINE_XEN_GUEST_HANDLE(physdev_dbgp_op_t);
> >  
> > + 
> > +#define PHYSDEVOP_map_iomem        30
> > +struct physdev_map_iomem {
> > +    /* IN */
> > +    unsigned long first_gfn;
> > +    unsigned long first_mfn;
> > +    unsigned int nr_mfns;
> > +    unsigned int add_mapping;        /* 1 == add mapping;  0 ==
> > unmap */ +
> > +};
> > +typedef struct physdev_map_iomem physdev_map_iomem_t;
> > +DEFINE_XEN_GUEST_HANDLE(physdev_map_iomem_t);
> > +
> 
> This needs documentation.  Also, the arguemnts should be explicitly
> sized to avoid compat difficulties. 
> 
> Tim.

Done:

/* Map given gfns to mfns where mfns are part of IO space. */
#define PHYSDEVOP_map_iomem        30
struct physdev_map_iomem {
    /* IN */
    uint64_t first_gfn;
    uint64_t first_mfn;
    uint32_t nr_mfns;
    uint32_t add_mapping;        /* 1 == add mapping;  0 == unmap */

};


thanks,
Mukesh