From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Tim Deegan <tim@xen.org>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
Subject: Re: [RFC PATCH 10/16]: PVH xen: introduce vmx_pvh.c
Date: Thu, 24 Jan 2013 18:15:33 -0800 [thread overview]
Message-ID: <20130124181533.7aa2e1a4@mantra.us.oracle.com> (raw)
In-Reply-To: <20130124163122.GJ20551@ocelot.phlegethon.org>
On Thu, 24 Jan 2013 16:31:22 +0000
Tim Deegan <tim@xen.org> wrote:
> At 18:01 -0800 on 11 Jan (1357927270), Mukesh Rathor wrote:
> That's a bit risky: EXIT_REASON_EXCEPTION_NMI includes a lot of cases
> that might not be safe to handle with interrupts disabled. Also I
> think it means there are paths through this function that don't
> enable irqs at all.
>
> I think it'd be better to do it the way vmx_vmexit_handler() does:
> explicitly sort out the things that _must_ be done with irqs disabled
> first, so it's clear which code runs with irqs enabled and which
> doesn't.
Yup, fixed already.
> This is a hard tab. Actually, the whitespace in this file needs
> attention generally.
rats, i turn tab on when making linux changes, and then on xen side
sometimes forget to turn them off. anyways, fixed.
thanks,
mukesh
next prev parent reply other threads:[~2013-01-25 2:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 2:01 [RFC PATCH 10/16]: PVH xen: introduce vmx_pvh.c Mukesh Rathor
2013-01-14 11:59 ` Jan Beulich
2013-01-15 0:54 ` Mukesh Rathor
2013-01-15 8:46 ` Jan Beulich
2013-01-24 1:59 ` Mukesh Rathor
2013-01-24 9:21 ` Jan Beulich
2013-01-25 2:29 ` Mukesh Rathor
2013-01-24 16:31 ` Tim Deegan
2013-01-25 2:15 ` Mukesh Rathor [this message]
2013-01-25 2:18 ` Mukesh Rathor
2013-02-20 0:05 ` Mukesh Rathor
2013-02-20 9:58 ` Tim Deegan
2013-02-21 3:05 ` Mukesh Rathor
2013-02-21 9:10 ` Tim Deegan
2013-02-21 19:20 ` Mukesh Rathor
2013-02-21 20:33 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124181533.7aa2e1a4@mantra.us.oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=Xen-devel@lists.xensource.com \
--cc=tim@xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).