From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [RFC PATCH 10/16]: PVH xen: introduce vmx_pvh.c
Date: Thu, 24 Jan 2013 18:15:33 -0800
Message-ID: <20130124181533.7aa2e1a4@mantra.us.oracle.com>
References: <20130111180110.55ce77aa@mantra.us.oracle.com>
	<20130124163122.GJ20551@ocelot.phlegethon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130124163122.GJ20551@ocelot.phlegethon.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tim Deegan <tim@xen.org>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 24 Jan 2013 16:31:22 +0000
Tim Deegan <tim@xen.org> wrote:

> At 18:01 -0800 on 11 Jan (1357927270), Mukesh Rathor wrote:
> That's a bit risky: EXIT_REASON_EXCEPTION_NMI includes a lot of cases
> that might not be safe to handle with interrupts disabled.  Also I
> think it means there are paths through this function that don't
> enable irqs at all.
> 
> I think it'd be better to do it the way vmx_vmexit_handler() does:
> explicitly sort out the things that _must_ be done with irqs disabled
> first, so it's clear which code runs with irqs enabled and which
> doesn't.

Yup, fixed already.

> This is a hard tab.  Actually, the whitespace in this file needs
> attention generally.

rats, i turn tab on when making linux changes, and then on xen side
sometimes forget to turn them off. anyways, fixed.

thanks,
mukesh