From: Tim Deegan <tim@xen.org>
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
Subject: Re: [RFC PATCH 5/16]: PVH xen: supporting changes.
Date: Fri, 25 Jan 2013 09:26:26 +0000 [thread overview]
Message-ID: <20130125092626.GA31562@ocelot.phlegethon.org> (raw)
In-Reply-To: <20130124174441.74362af0@mantra.us.oracle.com>
At 17:44 -0800 on 24 Jan (1359049481), Mukesh Rathor wrote:
> On Thu, 24 Jan 2013 15:22:21 +0000
> Tim Deegan <tim@xen.org> wrote:
>
> > At 17:48 -0800 on 11 Jan (1357926531), Mukesh Rathor wrote:
> > > In this patch, we make pv_cpuid() and emulate_forced_invalid_op()
> > > public to be used by PVH. Also put vmx functions like vmr(),
> > > get_instruction_length(), inlined in header file to be used by PVH.
> > > No real code change.
> >
> > Please don't export vmr(). It silently suppresses errors, which is OK
> > for its current use (as a helper function in the state dump) but not
> > for actual guest state manipulations.
>
> Ok, done.
Thanks.
> I'll assueme it's ok to export get_instruction_length().
Yes, that's fine as long as the warnings about when it's safe to use
are preserved! And, as Jan suggested, it should be renamed to
vmx_get_instruction_length().
Cheers,
Tim.
prev parent reply other threads:[~2013-01-25 9:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 1:48 [RFC PATCH 5/16]: PVH xen: supporting changes Mukesh Rathor
2013-01-14 11:27 ` Jan Beulich
2013-01-15 23:41 ` Mukesh Rathor
2013-01-16 9:47 ` Jan Beulich
2013-01-24 15:22 ` Tim Deegan
2013-01-25 1:44 ` Mukesh Rathor
2013-01-25 8:55 ` Jan Beulich
2013-01-25 9:26 ` Tim Deegan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125092626.GA31562@ocelot.phlegethon.org \
--to=tim@xen.org \
--cc=Xen-devel@lists.xensource.com \
--cc=mukesh.rathor@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).