From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH] mini-os: build fixes for lwip 1.3.2
Date: Mon, 28 Jan 2013 17:39:22 +0100
Message-ID: <20130128163922.GG6940@type.bordeaux.inria.fr>
References: <1359387552-23790-1-git-send-email-david.vrabel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1359387552-23790-1-git-send-email-david.vrabel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

David Vrabel, le Mon 28 Jan 2013 15:39:12 +0000, a =E9crit :
> - Endianness macros #defined in arch/cc.h.

These should rather go to endian.h, I guess lwip would be able to find
them there, shouldn't it?

> - free() is called via a function pointer so it needs to be a real
>   function.

For coherency, could you do the same with malloc and realloc?

>  #define malloc(size) _xmalloc(size, DEFAULT_ALIGN)
> -#define free(ptr) xfree(ptr)
>  #define realloc(ptr, size) _realloc(ptr, size)

Samuel