Re: [RFC PATCH 11/16]: PVH xen: some misc changes like mtrr, intr, msi.

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Thu, 24 Jan 2013 16:44:34 +0000
Tim Deegan <tim@xen.org> wrote:

> At 18:03 -0800 on 11 Jan (1357927436), Mukesh Rathor wrote:
> > diff -r 0a38c610f26b -r 33fc5356ad7c xen/arch/x86/time.c
> > --- a/xen/arch/x86/time.c	Fri Jan 11 16:34:17 2013 -0800
> > +++ b/xen/arch/x86/time.c	Fri Jan 11 16:35:48 2013 -0800
> > @@ -1923,7 +1923,7 @@ void tsc_set_info(struct domain *d,
> >          break;
> >      }
> >      d->arch.incarnation = incarnation + 1;
> > -    if ( is_hvm_domain(d) )
> > +    if ( is_hvm_or_pvh_domain(d) )
> >          hvm_set_rdtsc_exiting(d, d->arch.vtsc);
> >  }
> 
> The pvh vmexit handler in the last patch crashes the guest if it gets
> an RDTSC interception vmexit, so presumably either something should be
> added there or we need to make sure that d->arch.vtsc is never set on
> a PVH domain. 

Fixed. For now, making sure vtsc is not set for PVH. But, I added an
action item for Phase II to investigate and add support for it. At
first glance, staring at tsc code for couple hours, I'm still clueless.


Thanks,
Mukesh