From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [RFC PATCH 11/16]: PVH xen: some misc changes like
 mtrr, intr, msi.
Date: Thu, 31 Jan 2013 16:05:30 -0800
Message-ID: <20130131160530.6ce89e64@mantra.us.oracle.com>
References: <20130111180356.2eedfb82@mantra.us.oracle.com>
	<20130124164434.GK20551@ocelot.phlegethon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130124164434.GK20551@ocelot.phlegethon.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tim Deegan <tim@xen.org>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 24 Jan 2013 16:44:34 +0000
Tim Deegan <tim@xen.org> wrote:

> At 18:03 -0800 on 11 Jan (1357927436), Mukesh Rathor wrote:
> > diff -r 0a38c610f26b -r 33fc5356ad7c xen/arch/x86/time.c
> > --- a/xen/arch/x86/time.c	Fri Jan 11 16:34:17 2013 -0800
> > +++ b/xen/arch/x86/time.c	Fri Jan 11 16:35:48 2013 -0800
> > @@ -1923,7 +1923,7 @@ void tsc_set_info(struct domain *d,
> >          break;
> >      }
> >      d->arch.incarnation = incarnation + 1;
> > -    if ( is_hvm_domain(d) )
> > +    if ( is_hvm_or_pvh_domain(d) )
> >          hvm_set_rdtsc_exiting(d, d->arch.vtsc);
> >  }
> 
> The pvh vmexit handler in the last patch crashes the guest if it gets
> an RDTSC interception vmexit, so presumably either something should be
> added there or we need to make sure that d->arch.vtsc is never set on
> a PVH domain. 

Fixed. For now, making sure vtsc is not set for PVH. But, I added an
action item for Phase II to investigate and add support for it. At
first glance, staring at tsc code for couple hours, I'm still clueless.


Thanks,
Mukesh