From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
"stefano.stabellini@eu.citrix.com"
<stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] PVH linux: Use ballooning to allocate grant table pages
Date: Fri, 1 Feb 2013 15:51:32 -0800 [thread overview]
Message-ID: <20130201155132.71e0257c@mantra.us.oracle.com> (raw)
In-Reply-To: <20130201140058.156d3b9c@mantra.us.oracle.com>
On Fri, 1 Feb 2013 14:00:58 -0800
Mukesh Rathor <mukesh.rathor@oracle.com> wrote:
> On Thu, 31 Jan 2013 18:44:46 -0800
> Mukesh Rathor <mukesh.rathor@oracle.com> wrote:
>
> > On Thu, 31 Jan 2013 18:30:15 -0800
> > Mukesh Rathor <mukesh.rathor@oracle.com> wrote:
> >
> > > This patch fixes a fixme in Linux to use
> > > alloc_xenballooned_pages() to allocate pfns for grant table pages
> > > instead of kmalloc. This also simplifies add to physmap on the
> > > xen side a bit.
> >
> > Looking at it again, I realized rc should be signed in
> > gnttab_resume(). Below again. Thanks.
>
> Konrad, Please hold off on this patch. I discovered an issue on the
> domU side with this change. I'm currently investigating if it's
> related.
Ah right, I forgot the pfn's from balloon may not be always contigous.
Besides these are special pfns so to speak, so in gnttab_map()
virt_to_pfn doesn't work.
I'm gonna have to create a separate gnttab map routine for pvh case, it
appears. Shouldn't be too bad tho.
thanks,
Mukesh
next prev parent reply other threads:[~2013-02-01 23:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 2:30 [PATCH] PVH linux: Use ballooning to allocate grant table pages Mukesh Rathor
2013-02-01 2:44 ` [Xen-devel] " Mukesh Rathor
2013-02-01 22:00 ` Mukesh Rathor
2013-02-01 23:51 ` Mukesh Rathor [this message]
2013-02-06 15:49 ` Konrad Rzeszutek Wilk
2013-02-06 21:31 ` Mukesh Rathor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201155132.71e0257c@mantra.us.oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Xen-devel@lists.xensource.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).