From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Rathor Subject: Re: [Xen-devel] [PATCH] PVH linux: Use ballooning to allocate grant table pages Date: Fri, 1 Feb 2013 15:51:32 -0800 Message-ID: <20130201155132.71e0257c@mantra.us.oracle.com> References: <20130131183015.13bc2bff@mantra.us.oracle.com> <20130131184446.654a2289@mantra.us.oracle.com> <20130201140058.156d3b9c@mantra.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130201140058.156d3b9c@mantra.us.oracle.com> Sender: linux-kernel-owner@vger.kernel.org To: Mukesh Rathor Cc: Konrad Rzeszutek Wilk , "Xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" , Ian Campbell , "stefano.stabellini@eu.citrix.com" List-Id: xen-devel@lists.xenproject.org On Fri, 1 Feb 2013 14:00:58 -0800 Mukesh Rathor wrote: > On Thu, 31 Jan 2013 18:44:46 -0800 > Mukesh Rathor wrote: > > > On Thu, 31 Jan 2013 18:30:15 -0800 > > Mukesh Rathor wrote: > > > > > This patch fixes a fixme in Linux to use > > > alloc_xenballooned_pages() to allocate pfns for grant table pages > > > instead of kmalloc. This also simplifies add to physmap on the > > > xen side a bit. > > > > Looking at it again, I realized rc should be signed in > > gnttab_resume(). Below again. Thanks. > > Konrad, Please hold off on this patch. I discovered an issue on the > domU side with this change. I'm currently investigating if it's > related. Ah right, I forgot the pfn's from balloon may not be always contigous. Besides these are special pfns so to speak, so in gnttab_map() virt_to_pfn doesn't work. I'm gonna have to create a separate gnttab map routine for pvh case, it appears. Shouldn't be too bad tho. thanks, Mukesh