From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 03/13] xen: fix evtchn_unbind_from_user
Date: Tue, 5 Feb 2013 11:57:29 -0500
Message-ID: <20130205165728.GD2187@konrad-lan.dumpdata.com>
References: <1359643627-29486-1-git-send-email-wei.liu2@citrix.com>
	<1359643627-29486-4-git-send-email-wei.liu2@citrix.com>
	<510BA3B4.4010104@citrix.com>
	<1359721985.23229.109.camel@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1359721985.23229.109.camel@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, David Vrabel <david.vrabel@citrix.com>, "jbeulich@suse.com" <jbeulich@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, Feb 01, 2013 at 12:33:05PM +0000, Wei Liu wrote:
> On Fri, 2013-02-01 at 11:15 +0000, David Vrabel wrote:
> > On 31/01/13 14:46, Wei Liu wrote:
> > > It is possible the port was allocated but the irq was not. Take care of this
> > > case.
> > 
> > I think the port should be closed when the evtchn_bind_to_user() fails
> > otherwise the evtchn driver is leaving the event channel in an
> > inconsistent state.
> > 
> 
> Good point! I will move the fix there.

Ok, and in this function just do a BUG_ON(xx) if the case is still hit.

> 
> Wei.
>