xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Bastian Blank <waldi@debian.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [RFC] libxc: Add trusted decompressors
Date: Wed, 27 Feb 2013 13:44:43 +0100	[thread overview]
Message-ID: <20130227124443.GA5582@waldi.eu.org> (raw)
In-Reply-To: <1361967427.26546.368.camel@zakaz.uk.xensource.com>

On Wed, Feb 27, 2013 at 12:17:07PM +0000, Ian Campbell wrote:
> On Tue, 2013-02-26 at 22:32 +0000, Bastian Blank wrote:
> > Add trusted decompressors based on hypervisor code.
> > This are used in mini-os by pv-grub.
> I think this is a reasonably pragmatic way to arrange the build.

What should be fixed later:
- Use standard types in the decompressors (this both extends compiler
  support and portability)
- Remove stuff like always_inline (the compiler almost always knows
  better these days)

What should be done now:
- Drop bzip2 and lzma decoders. I have never seen bzip2 used anywhere
  because it is slow and lzma is replaced entirely by xz.
- Fix the arch detection for the xz bcj decoders.

> I'm not sure "trusted" is quite the right term though, these aren't
> really any more trustworthy than the library supplied ones -- they are
> just more suitable for a mini-os environment.

I used the term "trusted" because it should not be fed with untrusted
input. So it should not be used in the normal libxenguest. In the case
of pv-grub, all input is trusted as it runs in the same security domain.

Bastian

-- 
I'm frequently appalled by the low regard you Earthmen have for life.
		-- Spock, "The Galileo Seven", stardate 2822.3

  reply	other threads:[~2013-02-27 12:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04 11:56 [PATCH] pv-grub: Support bzip2, xz and lzo compressed kernels Ian Campbell
2013-01-04 12:15 ` Samuel Thibault
2013-01-04 12:43   ` Ian Campbell
2013-01-04 23:42     ` Samuel Thibault
2013-09-10 18:51     ` Matt Wilson
2013-09-10 19:05       ` Bastian Blank
2013-09-10 19:14         ` Matt Wilson
2013-01-04 12:33 ` Bastian Blank
2013-01-04 12:40   ` Ian Campbell
2013-02-26 22:25     ` Bastian Blank
2013-02-26 22:30       ` [RFC] libxc: Move compression support into own file Bastian Blank
2013-02-26 22:32       ` [RFC] libxc: Add trusted decompressors Bastian Blank
2013-02-27 12:17         ` Ian Campbell
2013-02-27 12:44           ` Bastian Blank [this message]
2013-02-27 14:28             ` Ian Campbell
2013-03-04 10:33             ` George Dunlap
2013-03-04 11:02               ` Tim Deegan
2013-03-12 15:21                 ` Ian Campbell
2013-03-02 20:16         ` [PATCH] " Bastian Blank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130227124443.GA5582@waldi.eu.org \
    --to=waldi@debian.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).