From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastian Blank Subject: Re: [RFC] libxc: Add trusted decompressors Date: Wed, 27 Feb 2013 13:44:43 +0100 Message-ID: <20130227124443.GA5582@waldi.eu.org> References: <1357300593-28685-1-git-send-email-ian.campbell@citrix.com> <20130104123307.GA1202@waldi.eu.org> <1357303220.14291.11.camel@zakaz.uk.xensource.com> <20130226222502.GB27098@waldi.eu.org> <20130226223249.GD27098@waldi.eu.org> <1361967427.26546.368.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1361967427.26546.368.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Wed, Feb 27, 2013 at 12:17:07PM +0000, Ian Campbell wrote: > On Tue, 2013-02-26 at 22:32 +0000, Bastian Blank wrote: > > Add trusted decompressors based on hypervisor code. > > This are used in mini-os by pv-grub. > I think this is a reasonably pragmatic way to arrange the build. What should be fixed later: - Use standard types in the decompressors (this both extends compiler support and portability) - Remove stuff like always_inline (the compiler almost always knows better these days) What should be done now: - Drop bzip2 and lzma decoders. I have never seen bzip2 used anywhere because it is slow and lzma is replaced entirely by xz. - Fix the arch detection for the xz bcj decoders. > I'm not sure "trusted" is quite the right term though, these aren't > really any more trustworthy than the library supplied ones -- they are > just more suitable for a mini-os environment. I used the term "trusted" because it should not be fed with untrusted input. So it should not be used in the normal libxenguest. In the case of pv-grub, all input is trusted as it runs in the same security domain. Bastian -- I'm frequently appalled by the low regard you Earthmen have for life. -- Spock, "The Galileo Seven", stardate 2822.3