From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Xu Zhang <xzhang@cs.uic.edu>
Cc: jeremy@goop.org, stefano.stabellini@eu.citrix.com,
gm281@cam.ac.uk, xen-devel@lists.xen.org
Subject: Re: [PATCH 3/6] mini-os/x86-64 entry: code refactoring; no functional changes
Date: Sat, 9 Mar 2013 22:03:35 +0100 [thread overview]
Message-ID: <20130309210335.GD6036@type.youpi.perso.aquilenet.fr> (raw)
In-Reply-To: <1362778219-8576-4-git-send-email-xzhang@cs.uic.edu>
Xu Zhang, le Fri 08 Mar 2013 15:30:16 -0600, a écrit :
> +#define XEN_GET_VCPU_INFO(reg) movq HYPERVISOR_shared_info,reg
> +#define XEN_PUT_VCPU_INFO(reg)
> +#define XEN_PUT_VCPU_INFO_fixup
> +#define XEN_LOCKED_BLOCK_EVENTS(reg) movb $1,evtchn_upcall_mask(reg)
> +#define XEN_LOCKED_UNBLOCK_EVENTS(reg) movb $0,evtchn_upcall_mask(reg)
> +#define XEN_TEST_PENDING(reg) testb $0xFF,evtchn_upcall_pending(reg)
> +
> +#define XEN_BLOCK_EVENTS(reg) XEN_GET_VCPU_INFO(reg) ; \
> + XEN_LOCKED_BLOCK_EVENTS(reg) ; \
> + XEN_PUT_VCPU_INFO(reg)
> +
> +#define XEN_UNBLOCK_EVENTS(reg) XEN_GET_VCPU_INFO(reg) ; \
> + XEN_LOCKED_UNBLOCK_EVENTS(reg) ; \
> + XEN_PUT_VCPU_INFO(reg)
I agree on moving those, as they don't really have a context.
> +/* Macros */
> +.macro zeroentry sym
> + movq (%rsp),%rcx
> + movq 8(%rsp),%r11
> + addq $0x10,%rsp /* skip rcx and r11 */
> + pushq $0 /* push error code/oldrax */
> + pushq %rax /* push real oldrax to the rdi slot */
> + leaq \sym(%rip),%rax
> + jmp error_entry
> +.endm
> +
> +.macro errorentry sym
> + movq (%rsp),%rcx
> + movq 8(%rsp),%r11
> + addq $0x10,%rsp /* rsp points to the error code */
> + pushq %rax
> + leaq \sym(%rip),%rax
> + jmp error_entry
> +.endm
I disagree on moving those, as they do have some context.
>
> ENTRY(hypervisor_callback)
> zeroentry hypervisor_callback2
>
> ENTRY(hypervisor_callback2)
> - movq %rdi, %rsp
> + movq %rdi, %rsp
Please avoid such kind of difference, or make it another patch.
> retint_kernel:
> retint_restore_args:
Please also drop these labels, they're not used.
I agree on the rest.
Samuel
next prev parent reply other threads:[~2013-03-09 21:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 21:30 [PATCH 0/6] mini-os: check and fix up against nested events in x86-64 kernel entry Xu Zhang
2013-03-08 21:30 ` [PATCH 1/6] mini-os/x86-64 entry: code clean-ups Xu Zhang
2013-03-09 20:57 ` Samuel Thibault
2013-03-08 21:30 ` [PATCH 2/6] mini-os/x86-64 entry: define macros for registers partial save and restore Xu Zhang
2013-03-09 20:55 ` Samuel Thibault
2013-03-08 21:30 ` [PATCH 3/6] mini-os/x86-64 entry: code refactoring; no functional changes Xu Zhang
2013-03-09 21:03 ` Samuel Thibault [this message]
2013-04-11 4:40 ` Xu Zhang
2013-03-08 21:30 ` [PATCH 4/6] mini-os/x86-64 entry: remove unnecessary event blocking Xu Zhang
2013-03-09 21:07 ` Samuel Thibault
2013-03-15 20:16 ` Konrad Rzeszutek Wilk
2013-04-11 4:40 ` Xu Zhang
2013-03-08 21:30 ` [PATCH 5/6] mini-os/x86-64 entry: defer RESTORE_REST until return Xu Zhang
2013-03-09 21:15 ` Samuel Thibault
2013-03-08 21:30 ` [PATCH 6/6] mini-os/x86-64 entry: check against nested events and try to fix up Xu Zhang
2013-03-09 21:19 ` Samuel Thibault
2013-03-13 2:42 ` Xu Zhang
2013-03-09 22:44 ` Jeremy Fitzhardinge
2013-03-13 2:42 ` Xu Zhang
2013-03-13 5:53 ` Xu Zhang
2013-03-14 1:09 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130309210335.GD6036@type.youpi.perso.aquilenet.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=gm281@cam.ac.uk \
--cc=jeremy@goop.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xzhang@cs.uic.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).