From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 4/6] mini-os/x86-64 entry: remove unnecessary event blocking Date: Fri, 15 Mar 2013 16:16:24 -0400 Message-ID: <20130315201624.GA30676@phenom.dumpdata.com> References: <1362778219-8576-1-git-send-email-xzhang@cs.uic.edu> <1362778219-8576-5-git-send-email-xzhang@cs.uic.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1362778219-8576-5-git-send-email-xzhang@cs.uic.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xu Zhang Cc: samuel.thibault@ens-lyon.org, jeremy@goop.org, stefano.stabellini@eu.citrix.com, gm281@cam.ac.uk, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, Mar 08, 2013 at 03:30:17PM -0600, Xu Zhang wrote: > We don't need to block events here because: > - if we came from "hypervisor_callback", events are disabled at this point, > no need to block again; Hm, I think I am not following it. It does a bit of %gs manipulation which looks to point to the cpu0_pda.irqcount. ? > - if we came from "error_entry", we shouldn't touch event mask, for > exception hanlding are meant to be interrupted by Xen events (virtual handling > irq). > > Signed-off-by: Xu Zhang > --- > extras/mini-os/arch/x86/x86_64.S | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/extras/mini-os/arch/x86/x86_64.S b/extras/mini-os/arch/x86/x86_64.S > index 79e893f..5e0021b 100644 > --- a/extras/mini-os/arch/x86/x86_64.S > +++ b/extras/mini-os/arch/x86/x86_64.S > @@ -185,7 +185,6 @@ ENTRY(hypervisor_callback2) > > error_exit: > RESTORE_REST > - XEN_BLOCK_EVENTS(%rsi) > > retint_kernel: > retint_restore_args: > -- > 1.7.7.6 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel >