From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 16/18 V2]: PVH xen: elf changes to pref for dom0 PVH.
Date: Mon, 18 Mar 2013 18:13:46 -0700 [thread overview]
Message-ID: <20130318181346.7483cd87@mantra.us.oracle.com> (raw)
In-Reply-To: <51471A0502000078000C65E2@nat28.tlf.novell.com>
On Mon, 18 Mar 2013 12:43:33 +0000
"Jan Beulich" <JBeulich@suse.com> wrote:
> >>> On 16.03.13 at 02:04, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> > + /* raw_copy_to_guest -> copy_to_user_hvm -> __hvm_copy needs
> > curr to
> > + * point to the hvm/pvh vcpu. Hence for PVH dom0 we can't use
> > that. For now
> > + * just use dbg_rw_mem(). */
>
> Again - definitely not outside of an RFC patch.
What, the "for now" comment, or the use of dbg_rw_mem()? There are fixme's in
xen already. dbg_rw_mem() is perfectly fine to use IMO, but in future we
may look at a faster copy, hence the comment.
Thanks,
M-
next prev parent reply other threads:[~2013-03-19 1:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 1:04 [PATCH 16/18 V2]: PVH xen: elf changes to pref for dom0 PVH Mukesh Rathor
2013-03-18 12:43 ` Jan Beulich
2013-03-19 1:13 ` Mukesh Rathor [this message]
2013-03-19 9:06 ` Jan Beulich
2013-03-18 18:05 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130318181346.7483cd87@mantra.us.oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).