From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [PATCH 16/18 V2]: PVH xen: elf changes to pref for
 dom0 PVH.
Date: Mon, 18 Mar 2013 18:13:46 -0700
Message-ID: <20130318181346.7483cd87@mantra.us.oracle.com>
References: <20130315180440.2b85af52@mantra.us.oracle.com>
	<51471A0502000078000C65E2@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51471A0502000078000C65E2@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, 18 Mar 2013 12:43:33 +0000
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 16.03.13 at 02:04, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> > +    /* raw_copy_to_guest -> copy_to_user_hvm -> __hvm_copy needs
> > curr to
> > +     * point to the hvm/pvh vcpu. Hence for PVH dom0 we can't use
> > that. For now
> > +     * just use dbg_rw_mem(). */
> 
> Again - definitely not outside of an RFC patch.

What, the "for now" comment, or the use of dbg_rw_mem()? There are fixme's in
xen already. dbg_rw_mem() is perfectly fine to use IMO, but in future we
may look at a faster copy, hence the comment.

Thanks,
M-